From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Ben Hutchings <ben@decadent.org.uk>,
James Bottomley <JBottomley@Parallels.com>
Subject: [ 8/8] SCSI: sd: Fix parsing of temporary cache mode prefix
Date: Thu, 11 Jul 2013 15:20:37 -0700 [thread overview]
Message-ID: <20130711221932.207762628@linuxfoundation.org> (raw)
In-Reply-To: <20130711221931.216612791@linuxfoundation.org>
3.0-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ben Hutchings <ben@decadent.org.uk>
commit 2ee3e26c673e75c05ef8b914f54fadee3d7b9c88 upstream.
Commit 39c60a0948cc '[SCSI] sd: fix array cache flushing bug causing
performance problems' added temp as a pointer to "temporary " and used
sizeof(temp) - 1 as its length. But sizeof(temp) is the size of the
pointer, not the size of the string constant. Change temp to a static
array so that sizeof() does what was intended.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/scsi/sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -138,7 +138,7 @@ sd_store_cache_type(struct device *dev,
char *buffer_data;
struct scsi_mode_data data;
struct scsi_sense_hdr sshdr;
- const char *temp = "temporary ";
+ static const char temp[] = "temporary ";
int len;
if (sdp->type != TYPE_DISK)
next prev parent reply other threads:[~2013-07-11 22:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 22:20 [ 0/8] 3.0.86-stable review Greg Kroah-Hartman
2013-07-11 22:20 ` [ 1/8] libceph: Fix NULL pointer dereference in auth client code Greg Kroah-Hartman
2013-07-11 22:20 ` [ 2/8] drivers/cdrom/cdrom.c: use kzalloc() for failing hardware Greg Kroah-Hartman
2013-07-11 22:20 ` [ 3/8] hpfs: better test for errors Greg Kroah-Hartman
2013-07-11 22:20 ` [ 4/8] block: do not pass disk names as format strings Greg Kroah-Hartman
2013-07-11 22:20 ` [ 5/8] crypto: sanitize argument for format string Greg Kroah-Hartman
2013-07-11 22:20 ` [ 6/8] MAINTAINERS: add stable_kernel_rules.txt to stable maintainer information Greg Kroah-Hartman
2013-07-12 3:36 ` Ben Hutchings
2013-07-12 3:48 ` Greg Kroah-Hartman
2013-07-11 22:20 ` [ 7/8] nfsd4: fix decoding of compounds across page boundaries Greg Kroah-Hartman
2013-07-11 22:20 ` Greg Kroah-Hartman [this message]
2013-07-12 13:54 ` [ 0/8] 3.0.86-stable review Guenter Roeck
2013-07-12 17:29 ` Greg Kroah-Hartman
2013-07-12 17:22 ` Shuah Khan
2013-07-13 4:17 ` Satoru Takeuchi
2013-07-13 4:48 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130711221932.207762628@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=JBottomley@Parallels.com \
--cc=ben@decadent.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).