From: Ben Hutchings <ben@decadent.org.uk>
To: KY Srinivasan <kys@microsoft.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"olaf@aepfle.de" <olaf@aepfle.de>,
"apw@canonical.com" <apw@canonical.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
Stable <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] Drivers: hv: balloon: Fix a bug in the hot-add code
Date: Fri, 12 Jul 2013 22:12:56 +0100 [thread overview]
Message-ID: <20130712211256.GC7729@decadent.org.uk> (raw)
In-Reply-To: <a53af503f3934a6bb8442e97de0d5ddc@SN2PR03MB061.namprd03.prod.outlook.com>
On Fri, Jul 12, 2013 at 09:07:19PM +0000, KY Srinivasan wrote:
[...]
> > Well now it might look like a bug that you don't test the result
> > of wait_for_completion_timeout(). Maybe update the comment to
> > explain why it's OK to continue anyway?
>
> I put in the comment in the patch explaining why it is ok to continue.
[...]
But that is not nearly as easy to see as the comment that is
already *in the code* which your patch isn't updating.
Ben.
--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert Camus
next prev parent reply other threads:[~2013-07-12 21:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1373637292-25855-1-git-send-email-kys@microsoft.com>
2013-07-12 13:56 ` [PATCH 1/2] Drivers: hv: balloon: Fix a bug in the hot-add code K. Y. Srinivasan
2013-07-12 13:56 ` [PATCH 2/2] Drivers: hv: balloon: Do not post pressure status if interrupted K. Y. Srinivasan
2013-07-12 20:17 ` [PATCH 1/2] Drivers: hv: balloon: Fix a bug in the hot-add code Ben Hutchings
2013-07-12 21:07 ` KY Srinivasan
2013-07-12 21:12 ` Ben Hutchings [this message]
2013-07-14 2:03 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130712211256.GC7729@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox