From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 12 Jul 2013 22:12:56 +0100 From: Ben Hutchings To: KY Srinivasan Cc: "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "olaf@aepfle.de" , "apw@canonical.com" , "jasowang@redhat.com" , Stable Message-ID: <20130712211256.GC7729@decadent.org.uk> References: <1373637292-25855-1-git-send-email-kys@microsoft.com> <1373637375-25936-1-git-send-email-kys@microsoft.com> <20130712201703.GB7729@decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [PATCH 1/2] Drivers: hv: balloon: Fix a bug in the hot-add code Sender: linux-kernel-owner@vger.kernel.org List-ID: On Fri, Jul 12, 2013 at 09:07:19PM +0000, KY Srinivasan wrote: [...] > > Well now it might look like a bug that you don't test the result > > of wait_for_completion_timeout(). Maybe update the comment to > > explain why it's OK to continue anyway? > > I put in the comment in the patch explaining why it is ok to continue. [...] But that is not nearly as easy to see as the comment that is already *in the code* which your patch isn't updating. Ben. -- Ben Hutchings We get into the habit of living before acquiring the habit of thinking. - Albert Camus