Re: [ 00/19] 3.10.1-stable review

Steven Rostedt
2013-07-16T21:27:39Z

On Tue, 2013-07-16 at 14:08 -0700, Sarah Sharp wrote:

>
> "Mauro, SHUT THE FUCK UP!"
>
> "How long have you been a maintainer? And you *still* haven't learnt the
> first rule of kernel maintenance?"
>
> "Shut up, Mauro. And I don't _ever_ want to hear that kind of obvious
> garbage and idiocy from a kernel maintainer again. Seriously."
>
> "The fact that you then try to make *excuses* for breaking user space,
> and blaming some external program that *used* to work, is just
> shameful. It's not how we work."
>
> "Fix your f*cking "compliance tool", because it is obviously broken.
> And fix your approach to kernel programming."
>
> "Seriously. Why do I even have to mention this? Why do I have to
> explain this to somebody pretty much *every* f*cking merge window?"
>
> "And btw, the *reason* for that rule becoming such a hard rule was
> pretty much exactly suspend/resume and ACPI. Exactly because we used
> to have those infinite "let's fix one thing and break another" dances.
> So you should be well acquainted with the rule, and I'm surprised to
> hear that kind of utter garbage from you in particular."

Reading all this again, it seems that Linus is pissed off at what Mauro
said, did or is doing. I don't really see a direct attack at Mauro as a
person. Not much different than being pissed off at someone asking Linus
to pull crap that's marked for stable. I see a very fine line between
the two.

Also, it seems that Linus is more disappointed with Mauro, as he expects
more from him.

Honestly, sometimes Linus needs to yell louder to top maintainers. As
its a way to wake us up that we need to be held to a higher regard.
Sometimes we may get complacent, and a bit lazy. If a top maintainer
starts to slack, major damage can be done. It needs to be serious.

I don't see the above as public shaming. It really just points out what
Linus expects from all maintainers, which would have been lost if this
were a private email.

>
>
> The personally directed verbal abuse is what I'm complaining about here.
> Linus goes from 0 to 11 at the drop of an "I don't think this is a
> regression" comment, and publicly ridicules his top maintainers.
>
> This is not right. This is not a community that people want to be a
> part of, except for a few top-tier maintainers who have "tough skins".
> No one should have to be the focus of a fire hose of personal verbal
> abuse.

I still don't see it as personal. Linus got pissed at what Mauro said
and did, not at Mauro as a person. Thus, not personal.

"I'm surprised to hear that kind of utter garbage from you in
particular"

I actually read the above as a complement.

>
> We're adults, not high schoolers. We can figure out how to deliver
> harsh technical criticism without resorting to name calling, cussing at
> people, or personal attacks.

Was there name calling in the above? I missed it.

>
> If a maintainer is not doing their job, Linus should send them a private
> harsh email, and a public email that simply says, "I'm reverting this
> pull request because of X. If this continues through the next merge
> window, this maintainer will need to train a replacement." Don't
> publicly tear them to pieces because they made a simple mistake.

That kind of email will most likely be ignored by people. A harsh email
becomes popular and noticed by a larger audience.

>
>
> The definition of insanity is repeating the same thing, over and over,
> expecting the result to be different. Linus keeps repeating the same
> mantras over and over to maintainers that forget rules like, "No
> regressions."

No, I think people have heard this. And sometimes we start to think:
well this one may be different. Seems that its the maintainers that try
to do the same thing over and over expecting a different result from
Linus which is what makes Linus insane.

>
> Why aren't we trying different tactics? Why aren't we improving our
> documentation so maintainers don't have to repeat themselves?

There's lots of documentation, and I think its more that maintainers
thinking "this time it's different" than anything else. I guarantee that
Mauro will not push userspace breakage again. And because of that email,
so will a lot of other maintainers.

-- Steve