From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 27 Jul 2013 21:16:16 -0700 From: Greg KH To: Ben Hutchings Cc: David Miller , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [ 06/79] net: Swap ver and type in pppoe_hdr Message-ID: <20130728041616.GA32761@kroah.com> References: <20130726204721.849052763@linuxfoundation.org> <20130726204722.608161811@linuxfoundation.org> <1374940708.13555.37.camel@deadeye.wl.decadent.org.uk> <20130727.175541.1879192128080680197.davem@davemloft.net> <1374981271.2476.0.camel@deadeye.wl.decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1374981271.2476.0.camel@deadeye.wl.decadent.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Sun, Jul 28, 2013 at 04:14:31AM +0100, Ben Hutchings wrote: > On Sat, 2013-07-27 at 17:55 -0700, David Miller wrote: > > From: Ben Hutchings > > Date: Sat, 27 Jul 2013 16:58:28 +0100 > > > > > I'm not so sure this is suitable for stable. It doesn't seem to be > > > helpful to either userland or kernel code. > > > > > > In the kernel, we were checking that ver == 1 and type == 1 thus this > > > wasn't hurting us. > > > > > > If userland does anything more with these fields then it's probably > > > already working around the swapped fields. It can work with both old > > > and new headers by doing: > > > > It's up to you, I would rather have the corrected version propagated > > as soon as possible. But that's just me. > > Let's see what Greg thinks. I'm guessing that Linus's tree is also "wrong" here, correct? If so, the fix that goes into that tree should also go here as well. Or am I confused? greg k-h