From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 28 Jul 2013 19:15:46 +0530 From: Vinod Koul To: Lars-Peter Clausen Cc: Dan Williams , Jassi Brar , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] dma: pl330: Fix cyclic transfers Message-ID: <20130728134546.GE1986@intel.com> References: <1374567890-27593-1-git-send-email-lars@metafoo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1374567890-27593-1-git-send-email-lars@metafoo.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Tue, Jul 23, 2013 at 10:24:50AM +0200, Lars-Peter Clausen wrote: > Allocate a descriptor for each period of a cyclic transfer, not just the first. > Also since the callback needs to be called for each finished period make sure to > initialize the callback and callback_param fields of each descriptor in a cyclic > transfer. > > Cc: stable@vger.kernel.org > Signed-off-by: Lars-Peter Clausen Applied thanks Btw the switch moved should have return error for default case when direction is not slave, but thats not in context of this as you moved that code ~Vinod