From: Greg KH <greg@kroah.com>
To: Nix <nix@esperi.org.uk>
Cc: Bernd Schubert <bernd.schubert@fastmail.fm>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org, nick.cheng@areca.com.tw,
stable@vger.kernel.org, Douglas Gilbert <dgilbert@interlog.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH] scsi disk: Use its own buffer for the vpd request
Date: Fri, 30 Aug 2013 18:53:37 -0700 [thread overview]
Message-ID: <20130831015337.GA8164@kroah.com> (raw)
In-Reply-To: <871u5b7azv.fsf@spindle.srvr.nix>
On Fri, Aug 30, 2013 at 11:01:56AM +0100, Nix wrote:
> On 1 Aug 2013, Bernd Schubert said:
>
> > Once I noticed that scsi_get_vpd_page() works fine from other function
> > calls and that it is not 0x89, but already 0x0 that fails fixing it became
> > easy.
> >
> > Nix, any chance you could verify it also works for you?
>
> As an aside, this commit does indeed fix the bug I reported, but it
> doesn't seem to have gone anywhere, not even into -stable.
>
> Is it held up somehow?
>
> (stable has
>
> commit 0ac10bd036f0f3b8ce7ac2390446eab9531c72eb
> Author: Martin K. Petersen <martin.petersen@oracle.com>
> Date: Tue Jul 30 22:58:34 2013 -0400
>
> SCSI: Don't attempt to send extended INQUIRY command if skip_vpd_pages is set
>
> which IIRC was eventually found not to be necessary, because this fix
> works fine instead?)
>
> Possibly I'm misremembering the order of month-old events and Martin's
> fix was eventually considered better... in which case, sorry for the noise.
Is that other patch even needed anymore, now that Martin's patch is in
the tree?
thanks,
greg k-h
next prev parent reply other threads:[~2013-08-31 1:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87r4ehfzhf.fsf@spindle.srvr.nix>
[not found] ` <51F667C2.4020801@fastmail.fm>
[not found] ` <87mwp5frdl.fsf@spindle.srvr.nix>
[not found] ` <51F67959.2060803@fastmail.fm>
2013-07-29 21:09 ` [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition Nix
2013-07-29 23:34 ` Martin K. Petersen
2013-07-30 18:09 ` Bernd Schubert
2013-07-31 0:07 ` Nick Alcock
2013-07-31 3:19 ` Martin K. Petersen
2013-07-31 3:15 ` Martin K. Petersen
2013-07-31 17:51 ` Bernd Schubert
2013-07-31 18:40 ` Bernd Schubert
2013-08-01 14:34 ` [PATCH] scsi disk: Use its own buffer for the vpd request Bernd Schubert
2013-08-01 14:37 ` Bernd Schubert
2013-08-02 3:00 ` Martin K. Petersen
2013-08-26 20:15 ` Bernd Schubert
2013-08-02 23:46 ` Nick Alcock
2013-08-03 11:17 ` Nick Alcock
2013-08-30 10:01 ` Nix
2013-08-31 1:53 ` Greg KH [this message]
2013-08-31 19:48 ` Nix
2013-09-01 18:40 ` Bernd Schubert
2013-09-20 22:51 ` Martin K. Petersen
2013-07-30 0:28 ` [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition Douglas Gilbert
2013-07-30 0:56 ` Nix
2013-07-30 18:14 ` Bernd Schubert
2013-07-30 21:20 ` Nix
2013-08-01 14:55 ` Bernd Schubert
2013-08-01 16:04 ` Nix
2013-08-01 16:21 ` Bernd Schubert
2013-07-31 3:10 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130831015337.GA8164@kroah.com \
--to=greg@kroah.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bernd.schubert@fastmail.fm \
--cc=dgilbert@interlog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nick.cheng@areca.com.tw \
--cc=nix@esperi.org.uk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).