From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-Id: <20130911042855.093490958@goodmis.org> Date: Wed, 11 Sep 2013 00:27:25 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Baruch Siach , Daniel Lezcano Subject: [018/251] clocksource: dw_apb: Fix error check References: <20130911042707.738353451@goodmis.org> Content-Disposition: inline; filename=0018-clocksource-dw_apb-Fix-error-check.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: 3.6.11.9-rc1 stable review patch. If anyone has any objections, please let me know. ------------------ From: Baruch Siach [ Upstream commit 1a33bd2be705cbb3f57d7223b60baea441039307 ] irq_of_parse_and_map() returns 0 on error, while the code checks for NO_IRQ. This breaks on platforms that have NO_IRQ != 0. Cc: Signed-off-by: Baruch Siach Signed-off-by: Daniel Lezcano Signed-off-by: Steven Rostedt --- drivers/clocksource/dw_apb_timer_of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clocksource/dw_apb_timer_of.c b/drivers/clocksource/dw_apb_timer_of.c index f7dba5b..929e7ce 100644 --- a/drivers/clocksource/dw_apb_timer_of.c +++ b/drivers/clocksource/dw_apb_timer_of.c @@ -44,7 +44,7 @@ static void add_clockevent(struct device_node *event_timer) u32 irq, rate; irq = irq_of_parse_and_map(event_timer, 0); - if (irq == NO_IRQ) + if (irq == 0) panic("No IRQ for clock event timer"); timer_get_base_and_rate(event_timer, &iobase, &rate); -- 1.7.10.4