From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miklos Szeredi , Steve French , Al Viro Subject: [ 04/71] cifs: fix filp leak in cifs_atomic_open() Date: Sun, 29 Sep 2013 12:27:16 -0700 Message-Id: <20130929192643.844649722@linuxfoundation.org> In-Reply-To: <20130929192643.539596256@linuxfoundation.org> References: <20130929192643.539596256@linuxfoundation.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: 3.11-stable review patch. If anyone has any objections, please let me know. ------------------ From: Miklos Szeredi commit dfb1d61b0e9f9e2c542e9adc8d970689f4114ff6 upstream. If an error occurs after having called finish_open() then fput() needs to be called on the already opened file. Signed-off-by: Miklos Szeredi Cc: Steve French Signed-off-by: Al Viro Signed-off-by: Greg Kroah-Hartman --- fs/cifs/dir.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/cifs/dir.c +++ b/fs/cifs/dir.c @@ -499,6 +499,7 @@ cifs_atomic_open(struct inode *inode, st if (server->ops->close) server->ops->close(xid, tcon, &fid); cifs_del_pending_open(&open); + fput(file); rc = -ENOMEM; }