From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 25 Oct 2013 19:20:32 +0900 From: Minchan Kim To: Weijie Yang Cc: akpm@linux-foundation.org, sjennings@variantweb.net, bob.liu@oracle.com, weijie.yang.kh@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH RESEND 2/2] mm/zswap: refoctor the get/put routines Message-ID: <20131025102032.GE6612@gmail.com> References: <000101ced09e$fed90a10$fc8b1e30$%yang@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000101ced09e$fed90a10$fc8b1e30$%yang@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Thu, Oct 24, 2013 at 05:53:32PM +0800, Weijie Yang wrote: > The refcount routine was not fit the kernel get/put semantic exactly, > There were too many judgement statements on refcount and it could be minus. > > This patch does the following: > > - move refcount judgement to zswap_entry_put() to hide resource free function. > > - add a new function zswap_entry_find_get(), so that callers can use easily > in the following pattern: > > zswap_entry_find_get > .../* do something */ > zswap_entry_put > > - to eliminate compile error, move some functions declaration > > This patch is based on Minchan Kim 's idea and suggestion. > > Signed-off-by: Weijie Yang > Cc: Seth Jennings > Cc: Minchan Kim > Cc: Bob Liu I remember Bob had a idea to remove a look up and I think it's doable. Anyway, I don't mind you send it with fix or not. Thanks for handling this, Weijie! Acked-by: Minchan Kim -- Kind regards, Minchan Kim