From: Greg KH <gregkh@linuxfoundation.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Khalid Aziz <khalid.aziz@oracle.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
bhelgaas@google.com, cl91tp@gmail.com, tianyu.lan@intel.com,
khlebnikov@openvz.org, gnomes@lxorguk.ukuu.org.uk,
indou.takao@jp.fujitsu.com, jility09@gmail.com, f.otti@gmx.at,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
kexec@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH] PCI: Clear Bus Master bit only on kexec reboot
Date: Wed, 27 Nov 2013 14:01:06 -0800 [thread overview]
Message-ID: <20131127220106.GA21887@kroah.com> (raw)
In-Reply-To: <20131127215309.GA15320@srcf.ucam.org>
On Wed, Nov 27, 2013 at 09:53:09PM +0000, Matthew Garrett wrote:
> On Wed, Nov 27, 2013 at 01:22:27PM -0800, Greg KH wrote:
>
> > Then fix the drivers please. It's not as if you don't have access to
> > the source for them all...
>
> Define "fix". It's clearly wrong to disable busmastering at shutdown on
> some devices, otherwise we wouldn't be having this discussion at all.
I thought it was only "wrong" to disable this on multi-function devices,
which is why some drivers didn't do it. Otherwise, how would it be any
different to have the global setting?
Anyway, I really don't care either way, but this seems like something
that the drivers should be doing. What suddenly changed that caused
this problem to occur that hasn't happened in the years prior to now
that drives this to be a stable-kernel issue?
greg k-h
next prev parent reply other threads:[~2013-11-27 22:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 19:18 [PATCH] PCI: Clear Bus Master bit only on kexec reboot Khalid Aziz
2013-11-27 19:24 ` Matthew Garrett
2013-11-27 19:48 ` Khalid Aziz
2013-11-27 19:53 ` Matthew Garrett
2013-11-27 19:38 ` Eric W. Biederman
2013-11-27 19:59 ` Khalid Aziz
2013-11-27 21:22 ` Greg KH
2013-11-27 21:53 ` Matthew Garrett
2013-11-27 22:01 ` Greg KH [this message]
2013-11-27 22:07 ` Matthew Garrett
2013-11-27 22:18 ` Khalid Aziz
2013-11-28 14:15 ` One Thousand Gnomes
2013-11-27 19:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131127220106.GA21887@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bhelgaas@google.com \
--cc=cl91tp@gmail.com \
--cc=ebiederm@xmission.com \
--cc=f.otti@gmx.at \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=indou.takao@jp.fujitsu.com \
--cc=jility09@gmail.com \
--cc=kexec@lists.infradead.org \
--cc=khalid.aziz@oracle.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=stable@vger.kernel.org \
--cc=tianyu.lan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox