From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
Khalid Aziz <khalid.aziz@oracle.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
bhelgaas@google.com, cl91tp@gmail.com, tianyu.lan@intel.com,
khlebnikov@openvz.org, indou.takao@jp.fujitsu.com,
jility09@gmail.com, f.otti@gmx.at, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
stable@vger.kernel.org
Subject: Re: [PATCH] PCI: Clear Bus Master bit only on kexec reboot
Date: Thu, 28 Nov 2013 14:15:13 +0000 [thread overview]
Message-ID: <20131128141513.3de95d04@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <20131127220106.GA21887@kroah.com>
> Anyway, I really don't care either way, but this seems like something
> that the drivers should be doing. What suddenly changed that caused
> this problem to occur that hasn't happened in the years prior to now
> that drives this to be a stable-kernel issue?
When this first went in I pointed out it was an utterly stupid idea.
Since it went in lots of machines haven't rebooted properly or powered
off right.
There are two problems
1. Clearing the busmaster bit is not well defined behaviour. It even
freezes some hardware.
2. Lots of PC class hardware has firmware which believes that it can
access the hardware as it goes to reboot or poweroff and that someone
won't have shut it down.
Like it or not the firmware expected behaviour for such things is "what
Windows did". The expected PC behaviour is subtle and magic - eg the fact
D3 on some IDE disk controllers is terminal until power cycled because
Windows didn't do that or that the BIOS goes off and chats to the disks
in reboot without assuming the disk controller is completely
uninitialized.
kexec is a special cornercase and handling is as such (knowing it will
bother to re-init appropriate devices) is very different to the current
broken behaviour for PC systems.
Alan
next prev parent reply other threads:[~2013-11-28 14:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 19:18 [PATCH] PCI: Clear Bus Master bit only on kexec reboot Khalid Aziz
2013-11-27 19:24 ` Matthew Garrett
2013-11-27 19:48 ` Khalid Aziz
2013-11-27 19:53 ` Matthew Garrett
2013-11-27 19:38 ` Eric W. Biederman
2013-11-27 19:59 ` Khalid Aziz
2013-11-27 21:22 ` Greg KH
2013-11-27 21:53 ` Matthew Garrett
2013-11-27 22:01 ` Greg KH
2013-11-27 22:07 ` Matthew Garrett
2013-11-27 22:18 ` Khalid Aziz
2013-11-28 14:15 ` One Thousand Gnomes [this message]
2013-11-27 19:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128141513.3de95d04@alan.etchedpixels.co.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=bhelgaas@google.com \
--cc=cl91tp@gmail.com \
--cc=ebiederm@xmission.com \
--cc=f.otti@gmx.at \
--cc=gregkh@linuxfoundation.org \
--cc=indou.takao@jp.fujitsu.com \
--cc=jility09@gmail.com \
--cc=kexec@lists.infradead.org \
--cc=khalid.aziz@oracle.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=stable@vger.kernel.org \
--cc=tianyu.lan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox