public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Ivajlo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
	"Ивайло Димитров" <freemangordon@abv.bg>,
	pali.rohar@gmail.com, sre@ring0.de, pavel@ucw.cz,
	omar.ramirez@copitl.com, felipe.contreras@gmail.com,
	s-anna@ti.com, nm@ti.com, ohad@wizery.com,
	stable@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Staging: tidspbridge: disable driver
Date: Sat, 30 Nov 2013 09:27:40 -0800	[thread overview]
Message-ID: <20131130172739.GE23334@atomide.com> (raw)
In-Reply-To: <20131130162023.GB15077@kroah.com>

* Greg KH <gregkh@linuxfoundation.org> [131130 08:20]:
> On Sat, Nov 30, 2013 at 11:58:23AM +0200, Ivajlo Dimitrov wrote:
> > Hi,
> > 
> > (re-sending in plain text, sorry for the noise)
> > 
> > commit 
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=930ba4a374b96560ef9fde2145cdc454a164ddcc
> > disables tidspbridge driver for the reasons it has a security bug and there 
> > is no active maintainer.
> > I was following the development of that driver for a bit and my impression 
> > was that the reason it is
> > still in staging is this 
> > http://www.spinics.net/lists/linux-omap/msg84115.html . And as dmtimer
> > driver is on its way to be merged upstream(or was it already merged?)  I was 
> > planning to work on
> > tidspbridge driver to fix it and send the patches. I also have a couple of 
> > another small patches
> > ready to be send.

I'd rather not just export 27 omap specific functions for the dmtimer to the
drivers knowing what kind of mess it will be.. There's some work happening
to make the dmtimer more generic, so for those parts we should have a solution
soonish.

> > However, could you elaborate on the "security bug" so I can try to fix it 
> > and send the patch?
> > Also, what needs to be done for the tidspdriver to get out of staging as it 
> > seems that what I
> > though initially is incorrect.
> 
> There is also the very long TODO list in drivers/staging/tidspbridge/
> 
> What is the progression on that?

Yeah and the tidspbridge should use the remoteproc which seems to be missing
from the TODO file. Anyways, the pending dmtimer work should not impact fixing
the other issues from development point of view.

Regards,

Tony

  reply	other threads:[~2013-11-30 17:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-30  9:58 Staging: tidspbridge: disable driver Ivajlo Dimitrov
2013-11-30 16:20 ` Greg KH
2013-11-30 17:27   ` Tony Lindgren [this message]
2013-11-30 19:19 ` Pavel Machek
2013-11-30 19:49   ` Dan Carpenter
2013-11-30 20:42     ` [patch] Staging: tidspbridge: make mmap root-only so it is not a security problem Pavel Machek
2013-11-30 22:05       ` Greg KH
2013-11-30 22:58         ` Pavel Machek
2013-12-01  3:45           ` Greg KH
2013-12-01  9:47             ` Pali Rohár
2013-12-01 11:26             ` Pavel Machek
2013-12-01 11:33               ` Pali Rohár
2013-12-01  9:41           ` Pali Rohár
2013-12-01  9:58             ` Ивайло Димитров
2013-12-01 12:10               ` Pavel Machek
2013-12-01 12:27                 ` Dan Carpenter
2013-12-01 18:14                   ` Ivajlo Dimitrov
2013-12-01 18:57                     ` Pavel Machek
2013-12-01 19:28                     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131130172739.GE23334@atomide.com \
    --to=tony@atomide.com \
    --cc=felipe.contreras@gmail.com \
    --cc=freemangordon@abv.bg \
    --cc=gregkh@linuxfoundation.org \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=ohad@wizery.com \
    --cc=omar.ramirez@copitl.com \
    --cc=pali.rohar@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=s-anna@ti.com \
    --cc=sre@ring0.de \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox