From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 30 Nov 2013 14:05:53 -0800 From: Greg KH To: Pavel Machek Cc: Dan Carpenter , Ivajlo Dimitrov , =?utf-8?B?0JjQstCw0LnQu9C+INCU0LjQvNC40YLRgNC+0LI=?= , pali.rohar@gmail.com, sre@ring0.de, omar.ramirez@copitl.com, tony@atomide.com, felipe.contreras@gmail.com, s-anna@ti.com, nm@ti.com, ohad@wizery.com, stable@vger.kernel.org, linux-kernel@vger.kernel.org, nico@ngolde.de Subject: Re: [patch] Staging: tidspbridge: make mmap root-only so it is not a security problem Message-ID: <20131130220553.GA1901@kroah.com> References: <6662B6F95D1C4783A007CAC82A8DA641@ivogl> <20131130191931.GA5286@amd.pavel.ucw.cz> <20131130194935.GG5443@mwanda> <20131130204237.GA17912@amd.pavel.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131130204237.GA17912@amd.pavel.ucw.cz> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Sat, Nov 30, 2013 at 09:42:37PM +0100, Pavel Machek wrote: > > mmap in tidspbridge is missing range-checks. For now, make this > interface root-only, so that it does not cause security problems. Please fix this properly and don't paper over the real problem here. thanks, greg k-h