From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 5 Dec 2013 08:58:35 -0500 From: Vivek Goyal To: Qais Yousef Cc: linux-kernel@vger.kernel.org, Andrew Morton , Michael Holzheu , linux-mips@linux-mips.org, stable@vger.kernel.org Subject: Re: [PATCH] crash_dump: fix compilation error (on MIPS at least) Message-ID: <20131205135835.GA1600@redhat.com> References: <1386172702-31266-1-git-send-email-qais.yousef@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1386172702-31266-1-git-send-email-qais.yousef@imgtec.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Wed, Dec 04, 2013 at 03:58:22PM +0000, Qais Yousef wrote: > In file included from kernel/crash_dump.c:2:0: > include/linux/crash_dump.h:22:27: error: unknown type name ‘pgprot_t’ > > when CONFIG_CRASH_DUMP=y > > The error was traced back to this commit: > > 9cb218131de1 vmcore: introduce remap_oldmem_pfn_range() > > include to get the missing definition > > Cc: Andrew Morton > Cc: Michael Holzheu > Cc: Vivek Goyal > Cc: > Cc: # 3.12 > Reviewed-by: James Hogan > Signed-off-by: Qais Yousef > --- Looks good to me. Acked-by: Vivek Goyal Vivek > I haven't tried any other architecture except mips. > If OK this should be considered for stable 3.12 (CCed). > > include/linux/crash_dump.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h > index fe68a5a..7032518 100644 > --- a/include/linux/crash_dump.h > +++ b/include/linux/crash_dump.h > @@ -6,6 +6,8 @@ > #include > #include > > +#include /* for pgprot_t */ > + > #define ELFCORE_ADDR_MAX (-1ULL) > #define ELFCORE_ADDR_ERR (-2ULL) > > -- > 1.7.1 >