From: Greg KH <gregkh@linuxfoundation.org>
To: Mateusz Guzik <mguzik@redhat.com>
Cc: stable@vger.kernel.org, Eryu Guan <eguan@redhat.com>,
Jeff Moyer <jmoyer@redhat.com>,
Kent Overstreet <kmo@daterainc.com>,
linux-aio@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3.10] aio: restore locking of ioctx list on removal
Date: Thu, 5 Dec 2013 17:03:47 -0800 [thread overview]
Message-ID: <20131206010347.GA25404@kroah.com> (raw)
In-Reply-To: <1386238142-21792-1-git-send-email-mguzik@redhat.com>
On Thu, Dec 05, 2013 at 11:09:02AM +0100, Mateusz Guzik wrote:
> Commit 36f5588905c10a8c4568a210d601fe8c3c27e0f0
> "aio: refcounting cleanup" resulted in ioctx_lock not being held
> during ctx removal, leaving the list susceptible to corruptions.
>
> In mainline kernel the issue went away as a side effect of
> db446a08c23d5475e6b08c87acca79ebb20f283c "aio: convert the ioctx list to
> table lookup v3".
>
> Fix the problem by restoring appropriate locking.
Why can't I just take db446a08c23d5475e6b08c87acca79ebb20f283c instead?
Does it not work well enough, or is there other issues involved in it
that would keep it out of stable?
Also, it seems like the performance increase of that patch would be good
to have backported, right?
thanks,
greg k-h
next prev parent reply other threads:[~2013-12-06 1:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 10:09 [PATCH 3.10] aio: restore locking of ioctx list on removal Mateusz Guzik
2013-12-06 1:03 ` Greg KH [this message]
2013-12-06 8:51 ` Mateusz Guzik
2013-12-06 14:53 ` Benjamin LaHaise
2013-12-09 10:49 ` Luis Henriques
2013-12-06 13:51 ` Benjamin LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206010347.GA25404@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=eguan@redhat.com \
--cc=jmoyer@redhat.com \
--cc=kmo@daterainc.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mguzik@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).