From: Benjamin LaHaise <bcrl@kvack.org>
To: Mateusz Guzik <mguzik@redhat.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Eryu Guan <eguan@redhat.com>,
Jeff Moyer <jmoyer@redhat.com>,
Kent Overstreet <kmo@daterainc.com>,
linux-aio@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3.10] aio: restore locking of ioctx list on removal
Date: Fri, 6 Dec 2013 09:53:43 -0500 [thread overview]
Message-ID: <20131206145343.GC13581@kvack.org> (raw)
In-Reply-To: <20131206085136.GA24844@mguzik.redhat.com>
Hi Greg, Mateusz,
On Fri, Dec 06, 2013 at 09:51:37AM +0100, Mateusz Guzik wrote:
> On Thu, Dec 05, 2013 at 05:03:47PM -0800, Greg KH wrote:
> > On Thu, Dec 05, 2013 at 11:09:02AM +0100, Mateusz Guzik wrote:
> > > Commit 36f5588905c10a8c4568a210d601fe8c3c27e0f0
> > > "aio: refcounting cleanup" resulted in ioctx_lock not being held
> > > during ctx removal, leaving the list susceptible to corruptions.
> > >
> > > In mainline kernel the issue went away as a side effect of
> > > db446a08c23d5475e6b08c87acca79ebb20f283c "aio: convert the ioctx list to
> > > table lookup v3".
> > >
> > > Fix the problem by restoring appropriate locking.
> >
> > Why can't I just take db446a08c23d5475e6b08c87acca79ebb20f283c instead?
> > Does it not work well enough, or is there other issues involved in it
> > that would keep it out of stable?
> >
> > Also, it seems like the performance increase of that patch would be good
> > to have backported, right?
> >
>
> Sorry, should have noted this in my original message:
> db446a08c23d5475e6b08c87acca79ebb20f283c is not trivial and applying it
> results in some conflicts, in addition to that the patch itself had bugs
> which were fixed in:
> da90382c2ec367aac88ff6aa76afb659ee0e4235
> f30d704fe1244c44a984d3d1f47bc648bcc6c9f7
> 77d30b14d24e557f89c41980011d72428514d729
> d9b2c8714aef102dea95544a8cd9372b21af463f
>
> It may be that the most convienent way to deal with this backport would
> be to just sync the file with mainline.
>
> As such, I think backporting is too risky at this stage.
Mateusz's analysis is correct. Backporting db446a08c23d5475e6b08c87acca79ebb20f283c
would essentially mean redoing the entire patch and would end up being a
bunch more untested code. Please take Mateusz's patch which fixes the bug
within a narrow scope. It is applicable to 3.10 and 3.11. For 3.12 the
issue is fixed by other changes. Feel free to add my Acked-by.
-ben
> Additionally my understanding of Documentation/stable_kernel_rules.txt
> was that somewhat simpler patches are preferred.
>
> So in the end I decided to fix the problem just by adding locking.
>
> Unfortunately at this time I can't volunteer to do the work if
> backporting is preferred.
>
> --
> Mateusz Guzik
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-aio' in
> the body to majordomo@kvack.org. For more info on Linux AIO,
> see: http://www.kvack.org/aio/
> Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
--
"Thought is the essence of where you are now."
next prev parent reply other threads:[~2013-12-06 14:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 10:09 [PATCH 3.10] aio: restore locking of ioctx list on removal Mateusz Guzik
2013-12-06 1:03 ` Greg KH
2013-12-06 8:51 ` Mateusz Guzik
2013-12-06 14:53 ` Benjamin LaHaise [this message]
2013-12-09 10:49 ` Luis Henriques
2013-12-06 13:51 ` Benjamin LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206145343.GC13581@kvack.org \
--to=bcrl@kvack.org \
--cc=eguan@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jmoyer@redhat.com \
--cc=kmo@daterainc.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mguzik@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).