stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org, Laxman Dewangan <ldewangan@nvidia.com>,
	Heiko Stuebner <heiko@sntech.de>, Pavel Machek <pavel@ucw.cz>,
	ian.campbell@citrix.com, rjw@rjwysocki.net, len.brown@intel.com,
	Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 3.4 13/25] irq: Enable all irqs unconditionally in irq_resume
Date: Tue, 10 Dec 2013 00:00:21 -0800	[thread overview]
Message-ID: <20131210075931.762016224@linuxfoundation.org> (raw)
In-Reply-To: <20131210075930.808460227@linuxfoundation.org>

3.4-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Laxman Dewangan <ldewangan@nvidia.com>

commit ac01810c9d2814238f08a227062e66a35a0e1ea2 upstream.

When the system enters suspend, it disables all interrupts in
suspend_device_irqs(), including the interrupts marked EARLY_RESUME.

On the resume side things are different. The EARLY_RESUME interrupts
are reenabled in sys_core_ops->resume and the non EARLY_RESUME
interrupts are reenabled in the normal system resume path.

When suspend_noirq() failed or suspend is aborted for any other
reason, we might omit the resume side call to sys_core_ops->resume()
and therefor the interrupts marked EARLY_RESUME are not reenabled and
stay disabled forever.

To solve this, enable all irqs unconditionally in irq_resume()
regardless whether interrupts marked EARLY_RESUMEhave been already
enabled or not.

This might try to reenable already enabled interrupts in the non
failure case, but the only affected platform is XEN and it has been
confirmed that it does not cause any side effects.

[ tglx: Massaged changelog. ]

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Acked-by-and-tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Pavel Machek <pavel@ucw.cz>
Cc: <ian.campbell@citrix.com>
Cc: <rjw@rjwysocki.net>
Cc: <len.brown@intel.com>
Cc: <gregkh@linuxfoundation.org>
Link: http://lkml.kernel.org/r/1385388587-16442-1-git-send-email-ldewangan@nvidia.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 kernel/irq/pm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/kernel/irq/pm.c
+++ b/kernel/irq/pm.c
@@ -50,7 +50,7 @@ static void resume_irqs(bool want_early)
 		bool is_early = desc->action &&
 			desc->action->flags & IRQF_EARLY_RESUME;
 
-		if (is_early != want_early)
+		if (!is_early && want_early)
 			continue;
 
 		raw_spin_lock_irqsave(&desc->lock, flags);



  parent reply	other threads:[~2013-12-10  8:00 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-10  8:00 [PATCH 3.4 00/25] 3.4.74-stable review Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 01/25] crypto: scatterwalk - Set the chain pointer indication bit Greg Kroah-Hartman
2013-12-10 14:46   ` Lendacky, Thomas
2013-12-11  2:02     ` Greg Kroah-Hartman
2013-12-11 14:51       ` Tom Lendacky
2013-12-10  8:00 ` [PATCH 3.4 02/25] crypto: ccm - Fix handling of zero plaintext when computing mac Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 03/25] crypto: authenc - Find proper IV address in ablkcipher callback Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 04/25] ASoC: wm8990: Mark the register map as dirty when powering down Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 05/25] ASoC: wm8731: fix dsp mode configuration Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 06/25] SCSI: enclosure: fix WARN_ON in dual path device removing Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 07/25] SCSI: libsas: fix usage of ata_tf_to_fis Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 08/25] SCSI: hpsa: do not discard scsi status on aborted commands Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 09/25] SCSI: hpsa: return 0 from driver probe function on success, not 1 Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 10/25] net: smc91: fix crash regression on the versatile Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 11/25] NFSv4: Update list of irrecoverable errors on DELEGRETURN Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 12/25] powerpc/gpio: Fix the wrong GPIO input data on MPC8572/MPC8536 Greg Kroah-Hartman
2013-12-10  8:00 ` Greg Kroah-Hartman [this message]
2013-12-10  8:00 ` [PATCH 3.4 14/25] net: update consumers of MSG_MORE to recognize MSG_SENDPAGE_NOTLAST Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 15/25] Input: allow deselecting serio drivers even without CONFIG_EXPERT Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 16/25] Input: mousedev - allow disabling " Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 17/25] um: add missing declaration of getrlimit() and friends Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 18/25] ahci: Add Device IDs for Intel Lynx Point-LP PCH Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 19/25] ahci: AHCI-mode SATA patch for Intel Avoton DeviceIDs Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 20/25] i2c: i801: SMBus " Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 21/25] USB: pl2303: fixed handling of CS5 setting Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 22/25] USB: mos7840: correct " Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 23/25] USB: spcp8x5: " Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 24/25] USB: cdc-acm: Added support for the Lenovo RD02-D400 USB Modem Greg Kroah-Hartman
2013-12-10  8:00 ` [PATCH 3.4 25/25] drivers/char/i8k.c: add Dell XPLS L421X Greg Kroah-Hartman
2013-12-10 17:01 ` [PATCH 3.4 00/25] 3.4.74-stable review Guenter Roeck
2013-12-11  1:17   ` Greg Kroah-Hartman
2013-12-11  1:48 ` Shuah Khan
2013-12-11 21:19 ` Satoru Takeuchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131210075931.762016224@linuxfoundation.org \
    --to=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=ian.campbell@citrix.com \
    --cc=ldewangan@nvidia.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).