From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 12 Dec 2013 14:25:18 +0100 From: Ingo Molnar To: John Stultz Cc: LKML , Thomas Gleixner , Prarit Bhargava , Richard Cochran , stable Subject: Re: [RFC][PATCH 4/5] timekeeping: Fix CLOCK_TAI timer/nanosleep delays Message-ID: <20131212132518.GB16360@gmail.com> References: <1386789098-17391-1-git-send-email-john.stultz@linaro.org> <1386789098-17391-5-git-send-email-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1386789098-17391-5-git-send-email-john.stultz@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: * John Stultz wrote: > A think-o in the calculation of the monotonic -> tai time offset > results in CLOCK_TAI timers and nanosleeps to expire late (the > latency is ~2x the tai offset). > > Fix this by adding the tai offset from the realtime offset instead > of subtracting. Hm, it looks like the whole CLOCK_TAI feature was rushed in, with not enough testing done. If the bugs extend to more than this two-liner then for -stable it might be better to just disable CLOCK_TAI (userspace can deal with it just fine), and queue up the right fixes for the next merge window or so. Thanks, Ingo