stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [git pull] fixes for 3.12-final
       [not found]           ` <20131113144353.GE28033@fieldses.org>
@ 2013-11-13 15:16             ` Bruce Fields
  2013-11-18 16:32               ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Bruce Fields @ 2013-11-13 15:16 UTC (permalink / raw)
  To: Al Viro; +Cc: Linus Torvalds, Linux Kernel Mailing List, linux-fsdevel, stable

(Argh, sorry, with the right stable address cc'd this time I hope.)

On Wed, Nov 06, 2013 at 03:10:04PM +0000, Al Viro wrote:
> FWIW, not taking ->i_lock there definitely looks like a good thing.  As for
> 64bit ->i_ino itself...  Looks like the main problem is the shitload of
> printks - the actual uses of ->i_ino are fine, but these suckers create
> a lot of noise.  So for now I'm going with Bruce's variant; 64bit i_ino
> doesn't look too bad (even on i386, actually), but it'll have to wait
> until 3.14.  Too noisy and late in this cycle...

I believe we also want that in stable?

950ee9566a5b6cc45d15f5fe044bab4f1e8b62cb "exportfs: fix 32-bit nfsd
handling of 64-bit inode numbers"

--b.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [git pull] fixes for 3.12-final
  2013-11-13 15:16             ` [git pull] fixes for 3.12-final Bruce Fields
@ 2013-11-18 16:32               ` Greg KH
  2013-12-18 19:40                 ` Bruce Fields
  0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2013-11-18 16:32 UTC (permalink / raw)
  To: Bruce Fields
  Cc: Al Viro, Linus Torvalds, Linux Kernel Mailing List, linux-fsdevel,
	stable

On Wed, Nov 13, 2013 at 10:16:55AM -0500, Bruce Fields wrote:
> (Argh, sorry, with the right stable address cc'd this time I hope.)
> 
> On Wed, Nov 06, 2013 at 03:10:04PM +0000, Al Viro wrote:
> > FWIW, not taking ->i_lock there definitely looks like a good thing.  As for
> > 64bit ->i_ino itself...  Looks like the main problem is the shitload of
> > printks - the actual uses of ->i_ino are fine, but these suckers create
> > a lot of noise.  So for now I'm going with Bruce's variant; 64bit i_ino
> > doesn't look too bad (even on i386, actually), but it'll have to wait
> > until 3.14.  Too noisy and late in this cycle...
> 
> I believe we also want that in stable?
> 
> 950ee9566a5b6cc45d15f5fe044bab4f1e8b62cb "exportfs: fix 32-bit nfsd
> handling of 64-bit inode numbers"

It breaks the build in 3.12 and others so if it is needed, please
provide a backport that works properly to stable@vger.kernel.org.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [git pull] fixes for 3.12-final
  2013-11-18 16:32               ` Greg KH
@ 2013-12-18 19:40                 ` Bruce Fields
  2013-12-18 20:12                   ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Bruce Fields @ 2013-12-18 19:40 UTC (permalink / raw)
  To: Greg KH
  Cc: Al Viro, Linus Torvalds, Linux Kernel Mailing List, linux-fsdevel,
	stable

On Mon, Nov 18, 2013 at 08:32:43AM -0800, Greg KH wrote:
> On Wed, Nov 13, 2013 at 10:16:55AM -0500, Bruce Fields wrote:
> > (Argh, sorry, with the right stable address cc'd this time I hope.)
> > 
> > On Wed, Nov 06, 2013 at 03:10:04PM +0000, Al Viro wrote:
> > > FWIW, not taking ->i_lock there definitely looks like a good thing.  As for
> > > 64bit ->i_ino itself...  Looks like the main problem is the shitload of
> > > printks - the actual uses of ->i_ino are fine, but these suckers create
> > > a lot of noise.  So for now I'm going with Bruce's variant; 64bit i_ino
> > > doesn't look too bad (even on i386, actually), but it'll have to wait
> > > until 3.14.  Too noisy and late in this cycle...
> > 
> > I believe we also want that in stable?
> > 
> > 950ee9566a5b6cc45d15f5fe044bab4f1e8b62cb "exportfs: fix 32-bit nfsd
> > handling of 64-bit inode numbers"
> 
> It breaks the build in 3.12 and others so if it is needed, please
> provide a backport that works properly to stable@vger.kernel.org.

Oops--there was a prerequisite patch that I forgot.  So we actually want

	git cherry-pick b7a6ec52dd4eced4a9bcda9ca85b3c8af84d3c90
	git cherry-pick 950ee9566a5b6cc45d15f5fe044bab4f1e8b62cb

--b.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [git pull] fixes for 3.12-final
  2013-12-18 19:40                 ` Bruce Fields
@ 2013-12-18 20:12                   ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2013-12-18 20:12 UTC (permalink / raw)
  To: Bruce Fields
  Cc: Al Viro, Linus Torvalds, Linux Kernel Mailing List, linux-fsdevel,
	stable

On Wed, Dec 18, 2013 at 02:40:34PM -0500, Bruce Fields wrote:
> On Mon, Nov 18, 2013 at 08:32:43AM -0800, Greg KH wrote:
> > On Wed, Nov 13, 2013 at 10:16:55AM -0500, Bruce Fields wrote:
> > > (Argh, sorry, with the right stable address cc'd this time I hope.)
> > > 
> > > On Wed, Nov 06, 2013 at 03:10:04PM +0000, Al Viro wrote:
> > > > FWIW, not taking ->i_lock there definitely looks like a good thing.  As for
> > > > 64bit ->i_ino itself...  Looks like the main problem is the shitload of
> > > > printks - the actual uses of ->i_ino are fine, but these suckers create
> > > > a lot of noise.  So for now I'm going with Bruce's variant; 64bit i_ino
> > > > doesn't look too bad (even on i386, actually), but it'll have to wait
> > > > until 3.14.  Too noisy and late in this cycle...
> > > 
> > > I believe we also want that in stable?
> > > 
> > > 950ee9566a5b6cc45d15f5fe044bab4f1e8b62cb "exportfs: fix 32-bit nfsd
> > > handling of 64-bit inode numbers"
> > 
> > It breaks the build in 3.12 and others so if it is needed, please
> > provide a backport that works properly to stable@vger.kernel.org.
> 
> Oops--there was a prerequisite patch that I forgot.  So we actually want
> 
> 	git cherry-pick b7a6ec52dd4eced4a9bcda9ca85b3c8af84d3c90
> 	git cherry-pick 950ee9566a5b6cc45d15f5fe044bab4f1e8b62cb

Thanks, I'll go take them now.

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-12-18 20:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20131103015803.GK13318@ZenIV.linux.org.uk>
     [not found] ` <CA+55aFy3tAeLYL3_+PbeD15p6PGS-P7bs8fMUaRVSC0OCzvq6w@mail.gmail.com>
     [not found]   ` <20131103195452.GL13318@ZenIV.linux.org.uk>
     [not found]     ` <CA+55aFwW9s3GCa+zNTMg7m44-cj2RdJp7wRpCnPUvQHm9xYnFg@mail.gmail.com>
     [not found]       ` <20131104005300.GM13318@ZenIV.linux.org.uk>
     [not found]         ` <20131106151003.GA21425@ZenIV.linux.org.uk>
     [not found]           ` <20131113144353.GE28033@fieldses.org>
2013-11-13 15:16             ` [git pull] fixes for 3.12-final Bruce Fields
2013-11-18 16:32               ` Greg KH
2013-12-18 19:40                 ` Bruce Fields
2013-12-18 20:12                   ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).