From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 17 Jan 2014 12:18:31 -0800 From: Greg KH To: Radim =?utf-8?B?S3LEjW3DocWZ?= Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, joro@8bytes.org, pbonzini@redhat.com, stable@vger.kernel.org Subject: Re: [PATCH] KVM: SVM: fix NMI window after iret Message-ID: <20140117201831.GA20561@kroah.com> References: <1389988362-15260-1-git-send-email-rkrcmar@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1389988362-15260-1-git-send-email-rkrcmar@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Jan 17, 2014 at 08:52:42PM +0100, Radim Krčmář wrote: > We should open NMI window right after an iret, but SVM exits before it. > We wanted to single step using the trap flag and then open it. > (or we could emulate the iret instead) > We don't do it since commit 3842d135ff2 (likely), because the iret exit > handler does not request an event, so NMI window remains closed until > the next exit. > > Fix this by making KVM_REQ_EVENT request in the iret handler. > > Signed-off-by: Radim Krčmář > --- > (btw. kvm-unit-tests weren't executed on SVM since Nov 2010, at least) > > arch/x86/kvm/svm.c | 1 + > 1 file changed, 1 insertion(+) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly.