From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] mfd: 88pm800: Fix I2C device resource leak if probe fails
Date: Wed, 12 Feb 2014 09:58:28 +0000 [thread overview]
Message-ID: <20140212095828.GW15081@lee--X1> (raw)
In-Reply-To: <1392198701-20547-1-git-send-email-k.kozlowski@samsung.com>
> During probe the driver allocates two dummy I2C devices for subchips in
> function pm800_pages_init(). Additionally this function allocates
> regmaps for these subchips. If any of these steps fail then these dummy
> I2C devices are not freed and resources leak.
>
> On pm800_pages_init() fail the driver must call pm800_pages_exit() to
> unregister dummy I2C devices.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/mfd/88pm800.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c
> index 7dca1e640970..28627c1ff9da 100644
> --- a/drivers/mfd/88pm800.c
> +++ b/drivers/mfd/88pm800.c
> @@ -586,8 +586,8 @@ static int pm800_probe(struct i2c_client *client,
> return 0;
>
> err_device_init:
> - pm800_pages_exit(chip);
> err_page_init:
> + pm800_pages_exit(chip);
> err_subchip_alloc:
> pm80x_deinit();
> out_init:
If you're going to do this, then can you clean-up the superfluous
goto labels please?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-02-12 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 9:51 [PATCH] mfd: 88pm800: Fix I2C device resource leak if probe fails Krzysztof Kozlowski
2014-02-12 9:58 ` Lee Jones [this message]
2014-02-12 10:10 ` [PATCH v2] " Krzysztof Kozlowski
2014-02-12 10:16 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212095828.GW15081@lee--X1 \
--to=lee.jones@linaro.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox