From: Mark Brown <broonie@kernel.org>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
stable@vger.kernel.org
Subject: Re: [PATCH v2 2/2] regulator: core: Replace direct ops->disable usage
Date: Thu, 20 Feb 2014 21:51:30 +0900 [thread overview]
Message-ID: <20140220125130.GQ2669@sirena.org.uk> (raw)
In-Reply-To: <1392894472-11956-3-git-send-email-mpa@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
On Thu, Feb 20, 2014 at 12:07:52PM +0100, Markus Pargmann wrote:
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -1908,8 +1908,6 @@ static int _regulator_do_disable(struct regulator_dev *rdev)
>
> trace_regulator_disable_complete(rdev_get_name(rdev));
>
> - _notifier_call_chain(rdev, REGULATOR_EVENT_DISABLE,
> - NULL);
> return 0;
> }
>
> @@ -1933,6 +1931,8 @@ static int _regulator_disable(struct regulator_dev *rdev)
> rdev_err(rdev, "failed to disable\n");
> return ret;
> }
> + _notifier_call_chain(rdev, REGULATOR_EVENT_DISABLE,
> + NULL);
> }
>
> rdev->use_count = 0;
This change doesn't seem obviously related?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-20 12:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1392894472-11956-1-git-send-email-mpa@pengutronix.de>
2014-02-20 11:07 ` [PATCH v2 1/2] regulator: core: Replace direct ops->enable usage Markus Pargmann
2014-02-20 11:07 ` [PATCH v2 2/2] regulator: core: Replace direct ops->disable usage Markus Pargmann
2014-02-20 12:03 ` Markus Pargmann
2014-02-20 12:51 ` Mark Brown [this message]
2014-02-20 13:01 ` Markus Pargmann
2014-02-20 13:17 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220125130.GQ2669@sirena.org.uk \
--to=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox