* [PATCH] MIPS: OCTEON: fix EARLY_PRINTK_8250 build failure
@ 2014-03-25 19:58 Aaro Koskinen
2014-03-27 7:40 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Aaro Koskinen @ 2014-03-25 19:58 UTC (permalink / raw)
To: Ralf Baechle, linux-mips, linux-kernel, David Daney; +Cc: Aaro Koskinen, stable
Enabling EARLY_PRINTK_8250 breaks OCTEON builds because of multiple
prom_putchar() implementations. OCTEON provides its own prom_putchar()
(also used by the watchdog driver), so we should prevent user from
selecting EARLY_PRINTK_8250 on OCTEON.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: stable@vger.kernel.org
---
arch/mips/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/Kconfig.debug b/arch/mips/Kconfig.debug
index b147e70..b27e65886 100644
--- a/arch/mips/Kconfig.debug
+++ b/arch/mips/Kconfig.debug
@@ -22,7 +22,7 @@ config EARLY_PRINTK
config EARLY_PRINTK_8250
bool "8250/16550 and compatible serial early printk driver"
- depends on EARLY_PRINTK
+ depends on EARLY_PRINTK && !CAVIUM_OCTEON_SOC
default n
help
If you say Y here, it will be possible to use a 8250/16550 serial
--
1.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: OCTEON: fix EARLY_PRINTK_8250 build failure
2014-03-25 19:58 [PATCH] MIPS: OCTEON: fix EARLY_PRINTK_8250 build failure Aaro Koskinen
@ 2014-03-27 7:40 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2014-03-27 7:40 UTC (permalink / raw)
To: Aaro Koskinen; +Cc: linux-mips, linux-kernel, David Daney, stable
On Tue, Mar 25, 2014 at 09:58:45PM +0200, Aaro Koskinen wrote:
> Enabling EARLY_PRINTK_8250 breaks OCTEON builds because of multiple
> prom_putchar() implementations. OCTEON provides its own prom_putchar()
> (also used by the watchdog driver), so we should prevent user from
> selecting EARLY_PRINTK_8250 on OCTEON.
There shouldn't be Octeon-specific code in the 8250-driver, not even
the Kconfig bits. Also other systems - at least Sibyte - affected
by the same issue so I went for a different patch.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-27 7:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-25 19:58 [PATCH] MIPS: OCTEON: fix EARLY_PRINTK_8250 build failure Aaro Koskinen
2014-03-27 7:40 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).