[GIT PULL 0/4] perf/urgent fixes

[GIT PULL 0/4] perf/urgent fixes

[Jiri Olsa]

hi Ingo,
please consider pulling

thanks,
jirka


The following changes since commit fd741edc25600e1660abd00b5c1bbe967018c6a0:

  Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/urgent (2014-04-20 09:53:55 +0200)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-urgent-for-mingo

for you to fetch changes up to de04f8657de9d3351a2d5880f1f7080b23b798cf:

  tools lib traceevent: Fix memory leak in pretty_print() (2014-04-23 13:19:30 +0200)

----------------------------------------------------------------
perf/urgent fixes:

Developer stuff:
. Fix memory leak and backward compatibility macros for pevent
  filter enums in traceevent library (Steven Rostedt)

. Disable libdw unwind for all but x86 arch (Jiri Olsa)

. Fix memory leak in sample_ustack (Masanari Iida)

Signed-off-by: Jiri Olsa <jolsa@redhat.com>

----------------------------------------------------------------
Jiri Olsa (1):
      perf tools: Disable libdw unwind for all but x86 arch

Masanari Iida (1):
      perf tests x86: Fix memory leak in sample_ustack()

Steven Rostedt (2):
      tools lib traceevent: Fix backward compatibility macros for pevent filter enums
      tools lib traceevent: Fix memory leak in pretty_print()

 tools/lib/traceevent/event-parse.c       | 1 +
 tools/lib/traceevent/event-parse.h       | 4 ++--
 tools/perf/arch/x86/tests/dwarf-unwind.c | 1 +
 tools/perf/config/Makefile               | 8 ++++++++
 4 files changed, 12 insertions(+), 2 deletions(-)

[PATCH 4/4] tools lib traceevent: Fix memory leak in pretty_print()

[Jiri Olsa]

From: Steven Rostedt <rostedt@goodmis.org>

Commit 12e55569a244 "tools lib traceevent: Use helper trace-seq in print
functions like kernel does" added a extra trace_seq helper to process
string arguments like the kernel does it. But the difference between the
kernel and the userspace library is that the kernel's trace_seq structure
has a static allocated buffer. The userspace one has a dynamically
allocated one. It requires a trace_seq_destroy(), otherwise it produces
a nasty memory leak.

Cc: stable@vger.kernel.org # 3.14+
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/20140422192330.6bb09bf8@gandalf.local.home
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
---
 tools/lib/traceevent/event-parse.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index baec7d8..b83184f 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -4344,6 +4344,7 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event
 					      format, len_arg, arg);
 				trace_seq_terminate(&p);
 				trace_seq_puts(s, p.buffer);
+				trace_seq_destroy(&p);
 				arg = arg->next;
 				break;
 			default:
-- 
1.8.3.1

Re: [GIT PULL 0/4] perf/urgent fixes

[Ingo Molnar]

* Jiri Olsa <jolsa@redhat.com> wrote:

> hi Ingo,
> please consider pulling
> 
> thanks,
> jirka
> 
> 
> The following changes since commit fd741edc25600e1660abd00b5c1bbe967018c6a0:
> 
>   Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/urgent (2014-04-20 09:53:55 +0200)
> 
> are available in the git repository at:
> 
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-urgent-for-mingo
> 
> for you to fetch changes up to de04f8657de9d3351a2d5880f1f7080b23b798cf:
> 
>   tools lib traceevent: Fix memory leak in pretty_print() (2014-04-23 13:19:30 +0200)
> 
> ----------------------------------------------------------------
> perf/urgent fixes:
> 
> Developer stuff:
> . Fix memory leak and backward compatibility macros for pevent
>   filter enums in traceevent library (Steven Rostedt)
> 
> . Disable libdw unwind for all but x86 arch (Jiri Olsa)
> 
> . Fix memory leak in sample_ustack (Masanari Iida)
> 
> Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> 
> ----------------------------------------------------------------
> Jiri Olsa (1):
>       perf tools: Disable libdw unwind for all but x86 arch
> 
> Masanari Iida (1):
>       perf tests x86: Fix memory leak in sample_ustack()
> 
> Steven Rostedt (2):
>       tools lib traceevent: Fix backward compatibility macros for pevent filter enums
>       tools lib traceevent: Fix memory leak in pretty_print()
> 
>  tools/lib/traceevent/event-parse.c       | 1 +
>  tools/lib/traceevent/event-parse.h       | 4 ++--
>  tools/perf/arch/x86/tests/dwarf-unwind.c | 1 +
>  tools/perf/config/Makefile               | 8 ++++++++
>  4 files changed, 12 insertions(+), 2 deletions(-)

Pulled, thanks a lot Jiri!

	Ingo