From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-Id: <20140512003204.166690989@1wt.eu> Date: Mon, 12 May 2014 02:33:25 +0200 From: Willy Tarreau To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ying Xue , "David S. Miller" , Willy Tarreau Subject: [ 085/143] atm: idt77252: fix dev refcnt leak In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: 2.6.32-longterm review patch. If anyone has any objections, please let me know. ------------------ From: Ying Xue [ Upstream commit b5de4a22f157ca345cdb3575207bf46402414bc1 ] init_card() calls dev_get_by_name() to get a network deceive. But it doesn't decrease network device reference count after the device is used. Signed-off-by: Ying Xue Signed-off-by: David S. Miller Signed-off-by: Willy Tarreau --- drivers/atm/idt77252.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c index e33ae00..adbaed5 100644 --- a/drivers/atm/idt77252.c +++ b/drivers/atm/idt77252.c @@ -3557,6 +3557,7 @@ init_card(struct atm_dev *dev) if (tmp) { memcpy(card->atmdev->esi, tmp->dev_addr, 6); + dev_put(tmp); printk("%s: ESI %02x:%02x:%02x:%02x:%02x:%02x\n", card->name, card->atmdev->esi[0], card->atmdev->esi[1], card->atmdev->esi[2], card->atmdev->esi[3], -- 1.7.12.2.21.g234cd45.dirty