From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-Id: <20140512003204.546049873@1wt.eu> Date: Mon, 12 May 2014 02:33:34 +0200 From: Willy Tarreau To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?ISO-8859-15?q?Salva=20Peir=F3?= , "David S. Miller" , Willy Tarreau Subject: [ 094/143] hamradio/yam: fix info leak in ioctl In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: 2.6.32-longterm review patch. If anyone has any objections, please let me know. ------------------ From: =?latin1?q?Salva=20Peir=F3?= [ Upstream commit 8e3fbf870481eb53b2d3a322d1fc395ad8b367ed ] The yam_ioctl() code fails to initialise the cmd field of the struct yamdrv_ioctl_cfg. Add an explicit memset(0) before filling the structure to avoid the 4-byte info leak. Signed-off-by: Salva Peir� Signed-off-by: David S. Miller Signed-off-by: Willy Tarreau --- drivers/net/hamradio/yam.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c index 694132e..1a1002d 100644 --- a/drivers/net/hamradio/yam.c +++ b/drivers/net/hamradio/yam.c @@ -1060,6 +1060,7 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) break; case SIOCYAMGCFG: + memset(&yi, 0, sizeof(yi)); yi.cfg.mask = 0xffffffff; yi.cfg.iobase = yp->iobase; yi.cfg.irq = yp->irq; -- 1.7.12.2.21.g234cd45.dirty