From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 12 May 2014 20:11:14 +0200 From: Willy Tarreau To: Jon Maloy Cc: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Ying Xue , Paul Gortmaker , "David S. Miller" Subject: Re: [ 072/143] tipc: fix lockdep warning during bearer initialization Message-ID: <20140512181114.GA21727@1wt.eu> References: <20140512003203.627061916@1wt.eu> <5370F0F0.1020606@ericsson.com> <20140512161613.GD19173@1wt.eu> <20140512171234.GA21366@1wt.eu> <537102BA.7090108@ericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <537102BA.7090108@ericsson.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Mon, May 12, 2014 at 01:19:54PM -0400, Jon Maloy wrote: > On 05/12/2014 01:12 PM, Willy Tarreau wrote: > > On Mon, May 12, 2014 at 04:41:00PM +0000, Jon Maloy wrote: > >> Sorry, I should have mentioned that it is still only in net-next. > >> It is pretty recent. > > > > OK indeed, got it here for reference : > > > > https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=7216cd949c9bd56 > > > > But anyway, what is mentionned in this commit is a number of changes that > > happened between 2.6.32 and 3.15, so I hardly see how the tipc_net_lock > > is obsolete in 2.6.32 if it does not have all these changes. I have counted > > 489 commits between 2.6.32 and 3.15-rc5 touching net/tipc, so surely we > > cannot count on what we have to get rid of this lock. > > > > Am I missing anything ? > > Ok. I missed the 2.6.32 part. I withdraw my objection. Ah OK now it's much easier for me to understand your point :-) No problem, Thanks! Willy