Re: [PATCH] x86: numa: drop ZONE_ALIGN

David Rientjes
2014-06-08T22:25:50Z

On Sun, 8 Jun 2014, Luiz Capitulino wrote:

> diff --git a/arch/x86/include/asm/numa.h b/arch/x86/include/asm/numa.h
> index 4064aca..01b493e 100644
> --- a/arch/x86/include/asm/numa.h
> +++ b/arch/x86/include/asm/numa.h
> @@ -9,7 +9,6 @@
> #ifdef CONFIG_NUMA
>
> #define NR_NODE_MEMBLKS (MAX_NUMNODES*2)
> -#define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT))
>
> /*
> * Too small node sizes may confuse the VM badly. Usually they
> diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c
> index 1d045f9..69f6362 100644
> --- a/arch/x86/mm/numa.c
> +++ b/arch/x86/mm/numa.c
> @@ -200,8 +200,6 @@ static void __init setup_node_data(int nid, u64 start, u64 end)
> if (end && (end - start) < NODE_MIN_SIZE)
> return;
>
> - start = roundup(start, ZONE_ALIGN);
> -
> printk(KERN_INFO "Initmem setup node %d [mem %#010Lx-%#010Lx]\n",
> nid, start, end - 1);
>

What ensures this start address is page aligned from the BIOS?