From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 10 Jul 2014 03:17:13 -0700 From: Christoph Hellwig To: KY Srinivasan Cc: Christoph Hellwig , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "ohering@suse.com" , "jbottomley@parallels.com" , "jasowang@redhat.com" , "apw@canonical.com" , "linux-scsi@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH 7/8] drivers: scsi: storvsc: Set srb_flags in all cases Message-ID: <20140710101713.GC1151@infradead.org> References: <1404866789-26910-1-git-send-email-kys@microsoft.com> <1404866812-26950-1-git-send-email-kys@microsoft.com> <1404866812-26950-7-git-send-email-kys@microsoft.com> <20140709084453.GG6012@infradead.org> <651b6b11c6d6415cb0046ce03b6b2c63@BY2PR03MB299.namprd03.prod.outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <651b6b11c6d6415cb0046ce03b6b2c63@BY2PR03MB299.namprd03.prod.outlook.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Wed, Jul 09, 2014 at 06:40:09PM +0000, KY Srinivasan wrote: > > On Tue, Jul 08, 2014 at 05:46:51PM -0700, K. Y. Srinivasan wrote: > > > Correctly set SRB flags for all valid I/O directions. Some IHV drivers > > > on the Windows host require this. > > > > What are IHV drivers? > > If the target is a SAN device, the host simply passes the request over to the native driver stack on the host. Some specific hardware (IHV - independent hadware vendor) drivers on Windows require that SRB flags be correctly set in all cases. > I'm fine with putting this in, but treating I/O request from guests as trusted in a hypervisor doesn't seem like a good idea in general..