From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
David Ahern <dsahern@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Andi Kleen <andi@firstfloor.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] perf tools: Fix build-id matching on vmlinux
Date: Thu, 4 Sep 2014 22:13:11 -0300 [thread overview]
Message-ID: <20140905011311.GB30520@kernel.org> (raw)
In-Reply-To: <8761h2ap9f.fsf@sejong.aot.lge.com>
Em Fri, Sep 05, 2014 at 09:23:56AM +0900, Namhyung Kim escreveu:
> Hmm.. now I'm curious that why the -H option is needed at all.. the perf
> record already wrote build-ids that are actually hits..
Probably because when 'perf buildid-list' was introduced 'perf record'
was inserting all the PERF_RECORD_MMAP dsos into the buildid-list, not
just the ones with hits.
Then, later on, 'perf record' probably moved to register just the ones
with hits.
This way -H ends up being a nop, i.e. should produce the same result as
'perf buildid-list' with no options.
If it doesn't, then it is a bug.
- Arnaldo
next prev parent reply other threads:[~2014-09-05 1:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 6:38 [PATCH] perf tools: Fix build-id matching on vmlinux Namhyung Kim
2014-09-04 2:44 ` Namhyung Kim
2014-09-04 14:18 ` Arnaldo Carvalho de Melo
2014-09-05 0:09 ` Namhyung Kim
2014-09-05 1:18 ` Arnaldo Carvalho de Melo
2014-09-05 1:42 ` Namhyung Kim
2014-09-05 2:30 ` Namhyung Kim
2014-09-04 14:37 ` Stephane Eranian
2014-09-05 0:23 ` Namhyung Kim
2014-09-05 1:13 ` Arnaldo Carvalho de Melo [this message]
2014-09-05 3:19 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905011311.GB30520@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=adrian.hunter@intel.com \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).