From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
David Ahern <dsahern@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Andi Kleen <andi@firstfloor.org>,
Stephane Eranian <eranian@google.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] perf tools: Fix build-id matching on vmlinux
Date: Thu, 4 Sep 2014 22:18:04 -0300 [thread overview]
Message-ID: <20140905011804.GC30520@kernel.org> (raw)
In-Reply-To: <87a96f9bci.fsf@sejong.aot.lge.com>
Em Fri, Sep 05, 2014 at 09:09:49AM +0900, Namhyung Kim escreveu:
> >> Before:
> >> $ perf record -a usleep 1
> >> $ perf buildid-list
> >> 00d5ff078efe1d30b8492854f259215fd877ce30 /lib/modules/3.16.0-rc2+/build/vmlinux
> >> 78186287bba77069a056a5ccbeb14b7fd2ca3a4b /usr/lib64/libc-2.17.so
> >> $ perf buildid-list -H
> >> 0000000000000000000000000000000000000000 [kernel.kallsyms]
> >> 78186287bba77069a056a5ccbeb14b7fd2ca3a4b /usr/lib64/libc-2.17.so
> >> After:
> >> $ perf record -a usleep 1
> >> $ perf buildid-list
> >> 00d5ff078efe1d30b8492854f259215fd877ce30 [kernel.kallsyms]
> > We are losing information, namely the pathname for the kernel used, that
> > may be useful in analysis.
> Right. That's a problem.
> > Why not make sure that if there is a build-id in the perf.data header,
> > then we completely refusing anything that doesn't match the build-id?
> > I.e. the name is irrelevant for this purpose, the contents, as keyed by
> > the build-id, is what matters.
> The perf report rebuilds machine states from the event records only. In
> this case, the kernel map was recorded in the name of [kernel.kallsyms]
> so it couldn't find the build-id from the table.
Ok, but then we can special case this one, no?
Somehow mark in the buildid table that that entry is the one for the
kernel and hook it up to the synthesized event that has the
[kernel.kallsyms].ref_reloc_sym entry.
- Arnaldo
next prev parent reply other threads:[~2014-09-05 1:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 6:38 [PATCH] perf tools: Fix build-id matching on vmlinux Namhyung Kim
2014-09-04 2:44 ` Namhyung Kim
2014-09-04 14:18 ` Arnaldo Carvalho de Melo
2014-09-05 0:09 ` Namhyung Kim
2014-09-05 1:18 ` Arnaldo Carvalho de Melo [this message]
2014-09-05 1:42 ` Namhyung Kim
2014-09-05 2:30 ` Namhyung Kim
2014-09-04 14:37 ` Stephane Eranian
2014-09-05 0:23 ` Namhyung Kim
2014-09-05 1:13 ` Arnaldo Carvalho de Melo
2014-09-05 3:19 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905011804.GC30520@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=adrian.hunter@intel.com \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).