Re: [PATCH v2] perf tools: Fix build-id matching on vmlinux

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Fri, Sep 05, 2014 at 10:22:40AM +0300, Adrian Hunter escreveu:
> On 09/05/2014 07:59 AM, Namhyung Kim wrote:
> > +++ b/tools/perf/util/machine.c
> > @@ -1060,10 +1060,14 @@ static int machine__process_kernel_mmap_event(struct machine *machine,
> >  				strlen(kmmap_prefix));
> >  		/*
> >  		 * Should be there already, from the build-id table in
> > -		 * the header.
> > +		 * the header (but maybe with a different name: "vmlinux").
> >  		 */
> > -		struct dso *kernel = __dsos__findnew(&machine->kernel_dsos,
> > -						     kmmap_prefix);
> > +		struct dso *kernel = dsos__find(&machine->kernel_dsos,
> > +						"vmlinux", true);
 
> Isn't "vmlinux" just the basename of the original file name, so if it had a
> different name this wouldn't work e.g. if the filename had been
> /boot/vmlinuz-3.11.0-26-generic then you would need
> "vmlinuz-3.11.0-26-generic" for this to work?

Yeah, looking for well known pathnames to then check if the build-id
matches the one we're looking for, be it because we obtained it from
/sys/kernel/notes (for the running kernel), or from the perf.data file
build-id table is ok, as we don't know where it is.

Plain sticking "vmlinux" there is not.

- Arnaldo