From: Johan Hovold <johan@kernel.org>
To: Frans Klaver <frans.klaver@xsens.com>
Cc: Johan Hovold <johan@kernel.org>,
stable@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: serial: ftdi_sio: add Awinda Station and Dongle products
Date: Fri, 10 Oct 2014 11:20:14 +0200 [thread overview]
Message-ID: <20141010092014.GC12494@localhost> (raw)
In-Reply-To: <20141010091209.GC3588@ci00147.xsens-tech.local>
On Fri, Oct 10, 2014 at 11:12:09AM +0200, Frans Klaver wrote:
> On Fri, Oct 10, 2014 at 11:01:17AM +0200, Johan Hovold wrote:
> > On Fri, Oct 10, 2014 at 10:44:54AM +0200, Frans Klaver wrote:
> > > diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
> > > index 5937b2d..be3fffe 100644
> > > --- a/drivers/usb/serial/ftdi_sio_ids.h
> > > +++ b/drivers/usb/serial/ftdi_sio_ids.h
> > > @@ -145,6 +145,8 @@
> > > #define XSENS_VID 0x2639
> > > #define XSENS_CONVERTER_PID 0xD00D /* Xsens USB-serial converter */
> > > #define XSENS_MTW_PID 0x0200 /* Xsens MTw */
> > > +#define XSENS_AWINDA_STATION_PID 0x0101
> > > +#define XSENS_AWINDA_DONGLE_PID 0x0102
> >
> > And sorted by PID here (even though the two current entries are not, you
> > could reorder them as well).
> >
> > I noticed that the below PIDs use the FTDI VID. Perhaps a comment or at
> > least a separating empty line would be appropriate.
> >
> > > #define XSENS_CONVERTER_0_PID 0xD388 /* Xsens USB converter */
> > > #define XSENS_CONVERTER_1_PID 0xD389 /* Xsens Wireless Receiver */
> > > #define XSENS_CONVERTER_2_PID 0xD38A
>
> I'll move the new entries up. How about I throw in a separate patch that
> cleans up stuff around the PID definitions? There's some alignment off
> as well. That doesn't need to go into stable, I think.
As long as you keep the clean up minimal (e.g. the reorder the two
entries above and add a comment or new line, skip the alignment bit) it
can all go in one patch along with the new PIDs.
That way there'll be no conflicts when future PID-patches get backported
to stable.
Thanks,
Johan
next prev parent reply other threads:[~2014-10-10 9:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 8:44 [PATCH] usb: serial: ftdi_sio: add Awinda Station and Dongle products Frans Klaver
2014-10-10 9:01 ` Johan Hovold
2014-10-10 9:12 ` Frans Klaver
2014-10-10 9:20 ` Johan Hovold [this message]
2014-10-10 9:25 ` Frans Klaver
2014-10-10 9:32 ` [PATCH v2] " Frans Klaver
2014-10-10 9:34 ` Johan Hovold
2014-10-10 9:45 ` Frans Klaver
2014-10-10 9:52 ` [PATCH] " Frans Klaver
2014-10-10 9:54 ` Johan Hovold
2014-10-10 10:32 ` Frans Klaver
2014-10-22 8:14 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141010092014.GC12494@localhost \
--to=johan@kernel.org \
--cc=frans.klaver@xsens.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).