From: David Cohen <david.a.cohen@linux.intel.com>
To: Felipe Balbi <balbi@ti.com>
Cc: gregkh@linuxfoundation.org, mina86@mina86.com,
r.baldyga@samsung.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Subject: Re: [PATCH v2] usb: ffs: fix regression when quirk_ep_out_aligned_size flag is set
Date: Mon, 13 Oct 2014 09:55:56 -0700 [thread overview]
Message-ID: <20141013165556.GA4034@psi-dev26.jf.intel.com> (raw)
In-Reply-To: <20141013153212.GE21709@saruman>
On Mon, Oct 13, 2014 at 10:32:12AM -0500, Felipe Balbi wrote:
> On Wed, Oct 08, 2014 at 02:12:18PM -0700, David Cohen wrote:
> > The commit '2e4c7553cd usb: gadget: f_fs: add aio support' broke the
> > quirk implemented to align buffer size to maxpacketsize on out endpoint.
> > As result, functionfs does not work on Intel platforms using dwc3 driver
> > (i.e. Bay Trail and Merrifield). This patch fixes the issue.
> >
> > This code is based on a previous Qiuxu's patch.
> >
> > Fixes: 2e4c7553cd (usb: gadget: f_fs: add aio support)
> > Cc: <stable@vger.kernel.org> # v3.16+
> > Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
> > Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
> > Acked-by: Michal Nazarewicz <mina86@mina86.com>
> > ---
> >
> > Hi,
> >
> > Since this is a feature that worked in past, this is meant for stable
> > versions >= 3.16 too.
> >
> > v1 to v2: just added Fixes, Cc and Acked-by lines on patch description.
>
> this adds a build warning for use of maybe unitialized data_len. Plese
> fix.
It's a false-positive warning. data_len is only initialized if halt != 0
and it's only used if halt != 0 too.
Do you prefer to initialize it to 0 during the declaration to silent the
compiler?
BR, David
>
> --
> balbi
next prev parent reply other threads:[~2014-10-13 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1412727486-479-1-git-send-email-david.a.cohen@linux.intel.com>
2014-10-08 21:12 ` [PATCH v2] usb: ffs: fix regression when quirk_ep_out_aligned_size flag is set David Cohen
2014-10-12 19:12 ` Al Viro
2014-10-12 19:58 ` Felipe Balbi
2014-10-13 15:32 ` Felipe Balbi
2014-10-13 16:55 ` David Cohen [this message]
2014-10-13 17:03 ` Felipe Balbi
2014-10-13 18:15 ` [PATCH v3] " David Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141013165556.GA4034@psi-dev26.jf.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=qiuxu.zhuo@intel.com \
--cc=r.baldyga@samsung.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).