From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 13 Oct 2014 09:55:56 -0700 From: David Cohen To: Felipe Balbi Cc: gregkh@linuxfoundation.org, mina86@mina86.com, r.baldyga@samsung.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Qiuxu Zhuo Subject: Re: [PATCH v2] usb: ffs: fix regression when quirk_ep_out_aligned_size flag is set Message-ID: <20141013165556.GA4034@psi-dev26.jf.intel.com> References: <1412727486-479-1-git-send-email-david.a.cohen@linux.intel.com> <1412802738-28839-1-git-send-email-david.a.cohen@linux.intel.com> <20141013153212.GE21709@saruman> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141013153212.GE21709@saruman> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Mon, Oct 13, 2014 at 10:32:12AM -0500, Felipe Balbi wrote: > On Wed, Oct 08, 2014 at 02:12:18PM -0700, David Cohen wrote: > > The commit '2e4c7553cd usb: gadget: f_fs: add aio support' broke the > > quirk implemented to align buffer size to maxpacketsize on out endpoint. > > As result, functionfs does not work on Intel platforms using dwc3 driver > > (i.e. Bay Trail and Merrifield). This patch fixes the issue. > > > > This code is based on a previous Qiuxu's patch. > > > > Fixes: 2e4c7553cd (usb: gadget: f_fs: add aio support) > > Cc: # v3.16+ > > Signed-off-by: David Cohen > > Signed-off-by: Qiuxu Zhuo > > Acked-by: Michal Nazarewicz > > --- > > > > Hi, > > > > Since this is a feature that worked in past, this is meant for stable > > versions >= 3.16 too. > > > > v1 to v2: just added Fixes, Cc and Acked-by lines on patch description. > > this adds a build warning for use of maybe unitialized data_len. Plese > fix. It's a false-positive warning. data_len is only initialized if halt != 0 and it's only used if halt != 0 too. Do you prefer to initialize it to 0 during the declaration to silent the compiler? BR, David > > -- > balbi