From: Peter Zijlstra <peterz@infradead.org>
To: Maxime COQUELIN <maxime.coquelin@st.com>
Cc: gong.chen@linux.intel.com, Ingo Molnar <mingo@kernel.org>,
" Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
tytso@mit.edu, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, kernel@stlinux.com, eric.paire@st.com
Subject: Re: [PATCH v3] bitops: Fix shift overflow in GENMASK macros
Date: Tue, 4 Nov 2014 14:27:31 +0100 [thread overview]
Message-ID: <20141104132731.GO3337@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1415098697-16304-1-git-send-email-maxime.coquelin@st.com>
On Tue, Nov 04, 2014 at 11:58:17AM +0100, Maxime COQUELIN wrote:
> On some 32 bits architectures, including x86, GENMASK(31, 0) returns 0
> instead of the expected ~0UL.
>
> This is the same on some 64 bits architectures with GENMASK_ULL(63, 0).
>
> This is due to an overflow in the shift operand, 1 << 32 for GENMASK,
> 1 << 64 for GENMASK_ULL.
>
> Fixes: 10ef6b0dffe404bcc54e94cb2ca1a5b18445a66b
> Cc: <stable@vger.kernel.org> #v3.13+
> Reported-by: Eric Paire <eric.paire@st.com>
> Suggested-by: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@st.com>
There doesn't appear to be a clear maintainer for this file, so I'll try
and stick in in tip.
Thanks!
next prev parent reply other threads:[~2014-11-04 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 10:58 [PATCH v3] bitops: Fix shift overflow in GENMASK macros Maxime COQUELIN
2014-11-04 13:27 ` Peter Zijlstra [this message]
2014-11-05 11:10 ` Rasmus Villemoes
2014-11-05 15:47 ` Maxime Coquelin
2014-11-05 16:44 ` Peter Zijlstra
2014-11-06 9:56 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104132731.GO3337@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=eric.paire@st.com \
--cc=gong.chen@linux.intel.com \
--cc=kernel@stlinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@st.com \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).