From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Chen-Yu Tsai <wens@csie.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] dmaengine: sun6i: Fix memcpy operation
Date: Wed, 12 Nov 2014 10:39:12 +0100 [thread overview]
Message-ID: <20141112093912.GL14919@lukather> (raw)
In-Reply-To: <20141112092506.GA24582@intel.com>
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
On Wed, Nov 12, 2014 at 02:55:06PM +0530, Vinod Koul wrote:
> On Tue, Nov 11, 2014 at 07:35:52PM +0100, Maxime Ripard wrote:
> > The prep_memcpy call was not setting any meaningful burst and width because it
> > was relying on the dma_slave_config was not set already.
> >
> > Rework the needed conversion functions, and hardcode the width and burst to
> > use.
> >
>
> Applied, thanks.
>
> For memcpy, reying on dma_slave-config wasnt the right idea to start with.
> Memcoy is supposed to work even without that
Yeah, I learned that the "hard" way :)
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-11-12 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 18:35 [PATCH] dmaengine: sun6i: Fix memcpy operation Maxime Ripard
2014-11-12 9:25 ` Vinod Koul
2014-11-12 9:39 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112093912.GL14919@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vinod.koul@intel.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).