stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Josh Boyer <jwboyer@fedoraproject.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 3.18 15/19] move d_rcu from overlapping d_child to overlapping d_alias
Date: Mon, 15 Dec 2014 21:34:28 +0000	[thread overview]
Message-ID: <20141215213428.GW22149@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+5PVA6jZgOeDko_b5y2i8rYaxq_QWSfeDJ4RtA-1uZW87G+4Q@mail.gmail.com>

On Mon, Dec 15, 2014 at 04:21:12PM -0500, Josh Boyer wrote:
> On Mon, Dec 15, 2014 at 11:38 AM, Josh Boyer <jwboyer@fedoraproject.org> wrote:
> > On Mon, Dec 15, 2014 at 11:34 AM, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> >> On Mon, Dec 15, 2014 at 10:46:50AM -0500, Josh Boyer wrote:
> >>> On Sun, Dec 14, 2014 at 12:21:26PM -0800, Greg Kroah-Hartman wrote:
> >>> >3.18-stable review patch.  If anyone has any objections, please let me know.
> >>> >
> >>> >------------------
> >>> >
> >>> >From: Al Viro <viro@zeniv.linux.org.uk>
> >>> >
> >>> >commit 946e51f2bf37f1656916eb75bd0742ba33983c28 upstream.
> >>> >
> >>> >Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> >>> >Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >>>
> >>> I noticed you don't have this (and the child commit) queued for 3.17.y.
> >>
> >> That is because:
> >>
> >>> The backport wasn't exactly straight-forward because of the d_external
> >>> stuff, but I took a swing at it.  After that, the other commit was a
> >>> quick cherry-pick.
> >>
> >> It wasn't a "simple" backport, and I didn't have the time.  I'm also
> >> going to drop 3.17 real-soon-now.
> >
> > Right, figured.  Fedora isn't going to rebase the stable releases to
> > 3.18 until 3.18.2-ish, and this fixes an issue so I thought I'd give
> > it a try.
> >
> >>> Al, does the below look correct for a backport on top of 3.17.6?  It
> >>> builds, but I haven't tested it yet.
> >>
> >> Testing would be great to do :)
> >
> > Working on it.  Just wanted to send it out early in case Al spotted
> > something obviously wrong and wanted to yell at me for it.
> 
> Finally got around to booting it.  Something is definitely wrong.  Sigh.

Start with moving WARN_ON() into dentry_free() (as it's done in mainline and
for the same reason)...

  reply	other threads:[~2014-12-15 21:34 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-14 20:21 [PATCH 3.18 00/19] 3.18.1-stable review Greg Kroah-Hartman
2014-12-14 20:21 ` [PATCH 3.18 01/19] Fix race condition between vxlan_sock_add and vxlan_sock_release Greg Kroah-Hartman
2014-12-14 20:21 ` [PATCH 3.18 02/19] gre: Set inner mac header in gro complete Greg Kroah-Hartman
2014-12-14 20:21 ` [PATCH 3.18 03/19] openvswitch: Fix flow mask validation Greg Kroah-Hartman
2014-12-14 20:21 ` [PATCH 3.18 04/19] mips: bpf: Fix broken BPF_MOD Greg Kroah-Hartman
2014-12-14 20:21 ` [PATCH 3.18 05/19] net: mvneta: fix Tx interrupt delay Greg Kroah-Hartman
2014-12-14 20:21 ` [PATCH 3.18 06/19] net: mvneta: fix race condition in mvneta_tx() Greg Kroah-Hartman
2014-12-14 20:21 ` [PATCH 3.18 08/19] tcp: fix more NULL deref after prequeue changes Greg Kroah-Hartman
2014-12-14 20:21 ` [PATCH 3.18 09/19] xen-netfront: use correct linear area after linearizing an skb Greg Kroah-Hartman
2014-12-14 20:21 ` [PATCH 3.18 10/19] net: fix suspicious rcu_dereference_check in net/sched/sch_fq_codel.c Greg Kroah-Hartman
2014-12-14 20:21 ` [PATCH 3.18 11/19] netlink: use jhash as hashfn for rhashtable Greg Kroah-Hartman
2014-12-14 20:21 ` [PATCH 3.18 12/19] rtlwifi: rtl8192ce: Fix editing error that causes silent memory corruption Greg Kroah-Hartman
2014-12-14 20:21 ` [PATCH 3.18 13/19] rtlwifi: rtl8192ce: Fix kernel crashes due to missing callback entry Greg Kroah-Hartman
2014-12-14 20:21 ` [PATCH 3.18 14/19] rtlwifi: rtl8192ce: Fix missing interrupt ready flag Greg Kroah-Hartman
2014-12-14 20:21 ` [PATCH 3.18 15/19] move d_rcu from overlapping d_child to overlapping d_alias Greg Kroah-Hartman
2014-12-15 15:46   ` Josh Boyer
2014-12-15 16:34     ` Greg Kroah-Hartman
2014-12-15 16:38       ` Josh Boyer
2014-12-15 21:21         ` Josh Boyer
2014-12-15 21:34           ` Al Viro [this message]
2014-12-15 21:44             ` Josh Boyer
2014-12-16 13:25               ` Josh Boyer
2014-12-15 21:33     ` Al Viro
2014-12-14 20:21 ` [PATCH 3.18 16/19] deal with deadlock in d_walk() Greg Kroah-Hartman
2014-12-14 20:21 ` [PATCH 3.18 17/19] ALSA: hda - Add EAPD fixup for ASUS Z99He laptop Greg Kroah-Hartman
2014-12-14 20:21 ` [PATCH 3.18 18/19] ALSA: hda - Fix built-in mic at resume on Lenovo Ideapad S210 Greg Kroah-Hartman
2014-12-14 20:21 ` [PATCH 3.18 19/19] ALSA: usb-audio: Dont resubmit pending URBs at MIDI error recovery Greg Kroah-Hartman
2014-12-15  3:33 ` [PATCH 3.18 00/19] 3.18.1-stable review Guenter Roeck
2014-12-15  4:24   ` Greg Kroah-Hartman
2014-12-16  3:08 ` Shuah Khan
2014-12-16 16:12   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141215213428.GW22149@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=jwboyer@fedoraproject.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).