From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 19 Jan 2015 10:34:09 -0800 From: Tony Lindgren To: Jason Cooper Cc: Felipe Balbi , Thomas Gleixner , Aaro Koskinen , Linux ARM Kernel Mailing List , Linux OMAP Mailing List , Linux Kernel Mailing List , Peter =?utf-8?Q?K=C3=BCmmel?= , Pavel Machek , Santosh Shilimkar , stable@vger.kernel.org Subject: Re: [PATCH v2] irqchip: omap-intc: fix legacy DMA regression Message-ID: <20150119183409.GZ18552@atomide.com> References: <1420563093-26026-1-git-send-email-balbi@ti.com> <1420576688-10604-1-git-send-email-balbi@ti.com> <20150107030029.GE24989@titan.lakedaemon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150107030029.GE24989@titan.lakedaemon.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: * Jason Cooper [150106 19:03]: > On Tue, Jan 06, 2015 at 02:38:08PM -0600, Felipe Balbi wrote: > > commit 55601c9f2467 (arm: omap: intc: switch over > > to linear irq domain) introduced a regression with > > SDMA legacy driver because that driver strictly depends > > on INTC's IRQs starting at NR_IRQs. Aparently > > irq_domain_add_linear() won't guarantee that, since we see > > a 7 IRQs difference when booting with and without the > > commit cited above. > > > > Until arch/arm/plat-omap/dma.c is properly fixed, we > > must maintain OMAP2/3 using irq_domain_add_legacy(). > > > > A FIXME note was added so people know to delete that > > code once that legacy DMA driver is fixed up. > > > > Fixes: 55601c9f2467 (arm: omap: intc: switch over to linear irq domain) > > Cc: # v3.18 > > Tested-by: Aaro Koskinen > > Tested-by: Tony Lindgren > > Signed-off-by: Felipe Balbi > > --- > > drivers/irqchip/irq-omap-intc.c | 26 +++++++++++++++++++++----- > > 1 file changed, 21 insertions(+), 5 deletions(-) > > Applied to irqchip/urgent. Thanks for taking care of the Fixes and > stable tags! Jason, I'm not seeing this merged into v3.19-rc5, seems to be in Linux next though. Regards, Tony