From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 25 Jan 2015 09:38:53 -0800 From: Greg Kroah-Hartman To: Mark Brown Cc: Esben Haabendal , stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Stefan Roese Subject: Re: Backport of spi-fsl-spi bugfix to 3.14.y Message-ID: <20150125173853.GA6467@kroah.com> References: <1420472564.803.9.camel@gmail.com> <20150105154834.GV11764@sirena.org.uk> <20150123124529.GU21293@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150123124529.GU21293@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Fri, Jan 23, 2015 at 12:45:29PM +0000, Mark Brown wrote: > On Tue, Jan 06, 2015 at 10:15:47PM +0100, Esben Haabendal wrote: > > On 5 January 2015 at 16:48, Mark Brown wrote: > > > >> Please consider commit 4302a59629f7a0bd70fd1605d2b558597517372a > > >> (spi: fsl: Fix problem with multi message transfers) for inclusion in > > >> stable kernel 3.14. > > > >> It fixes a regression when using mmc_spi driver on top of spi-fsl-spi > > >> driver (tested with powerpc mpc8313 based board). > > > > Has this ever worked? > > > Yes, I have used mmc_spi with spi-fsl-spi on the same board with success > > with in 2.6.33, 3.0 and 3.4. > > > I have no idea what has caused this to break. Maybe mmc_spi driver was > > not doing multi message transfers earlier? > > So, I now see this has actually been merged into stable without getting > to the bottom of why it's helping anything... this is a bit worrying > since it's adding new functionality and not really a bug fix. It'd have > been good to at least get a followup here. Do you want me to revert something from the stable tree? If so, has it also been reverted upstream? confused, greg k-h