From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Date: Sun, 25 Jan 2015 13:31:49 -0800
From: Guenter Roeck <linux@roeck-us.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Hans Holmberg <hans.holmberg@intel.com>,
	Alexandre Courbot <acourbot@nvidia.com>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 3.10 25/50] gpiolib: of: Correct error handling in
 of_get_named_gpiod_flags
Message-ID: <20150125213149.GA3313@roeck-us.net>
References: <20150125180702.521559311@linuxfoundation.org>
 <20150125180703.970882239@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150125180703.970882239@linuxfoundation.org>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Sun, Jan 25, 2015 at 10:07:15AM -0800, Greg Kroah-Hartman wrote:
> 3.10-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Hans Holmberg <hans.holmberg@intel.com>
> 
> commit 7b8792bbdffdff3abda704f89c6a45ea97afdc62 upstream.
> 
> of_get_named_gpiod_flags fails with -EPROBE_DEFER in cases
> where the gpio chip is available and the GPIO translation fails.
> 
> This causes drivers to be re-probed erroneusly, and hides the
> real problem(i.e. the GPIO number being out of range).
> 
> Signed-off-by: Hans Holmberg <hans.holmberg@intel.com>
> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 

This patch is causing several build failures.

Error log:
drivers/gpio/gpiolib-of.c: In function 'of_gpiochip_find_and_xlate':
drivers/gpio/gpiolib-of.c:50:3: error: implicit declaration of function 'ERR_PTR'

since "#include <linux/err.h>" is missing in drivers/gpio/gpiolib-of.c
in the 3.10 kernel.

Guenter