From: Mike Turquette <mturquette@linaro.org>
To: Soren Brinkmann <soren.brinkmann@xilinx.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Stephen Boyd" <sboyd@codeaurora.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Soren Brinkmann" <soren.brinkmann@xilinx.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] clk: zynq: Force CPU_2X clock to be ungated
Date: Tue, 27 Jan 2015 17:01:30 -0800 [thread overview]
Message-ID: <20150128010130.22722.42627@quantum> (raw)
In-Reply-To: <1422385549-2550-1-git-send-email-soren.brinkmann@xilinx.com>
Quoting Soren Brinkmann (2015-01-27 11:05:27)
> The CPU_2X clock does not have a classical in-kernel user, but is,
> amongst other things, required for OCM and debug access. Make sure this
> clock is not mistakenly disabled during boot up by enabling it in the
> platform's clock driver.
>
> Cc: stable@vger.kernel.org # 3.11+
> Fixes: 0ee52b157b8e 'clk: zynq: Add clock controller driver'
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Applied to clk-next.
Regards,
Mike
> ---
> v2:
> - Fixed some typo's in the commit message
> - added Fixes and Cc tags to commit message
>
> As reference, the v1 submission: https://patchwork.kernel.org/patch/5698251/
> ---
> drivers/clk/zynq/clkc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/zynq/clkc.c b/drivers/clk/zynq/clkc.c
> index 9037bebd69f7..f870aad57711 100644
> --- a/drivers/clk/zynq/clkc.c
> +++ b/drivers/clk/zynq/clkc.c
> @@ -303,6 +303,7 @@ static void __init zynq_clk_setup(struct device_node *np)
> clks[cpu_2x] = clk_register_gate(NULL, clk_output_name[cpu_2x],
> "cpu_2x_div", CLK_IGNORE_UNUSED, SLCR_ARM_CLK_CTRL,
> 26, 0, &armclk_lock);
> + clk_prepare_enable(clks[cpu_2x]);
>
> clk = clk_register_fixed_factor(NULL, "cpu_1x_div", "cpu_div", 0, 1,
> 4 + 2 * tmp);
> --
> 2.2.2.1.g63c5777
>
prev parent reply other threads:[~2015-01-28 1:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 19:05 [PATCH v2] clk: zynq: Force CPU_2X clock to be ungated Soren Brinkmann
2015-01-28 1:01 ` Mike Turquette [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150128010130.22722.42627@quantum \
--to=mturquette@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=sboyd@codeaurora.org \
--cc=soren.brinkmann@xilinx.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).