From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Huang Ying <ying.huang@intel.com>,
linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>,
Pranith Kumar <bobby.prani@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] llist: Fix missing lockless_dereference()
Date: Sat, 7 Feb 2015 16:09:55 -0800 [thread overview]
Message-ID: <20150208000955.GG5418@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150207221625.GB31119@kroah.com>
On Sun, Feb 08, 2015 at 06:16:25AM +0800, Greg KH wrote:
> On Fri, Feb 06, 2015 at 09:08:21PM -0500, Mathieu Desnoyers wrote:
> > A lockless_dereference() appears to be missing in llist_del_first().
> > It should only matter for Alpha in practice.
>
> Meta-comment, do we really care about Alpha anymore? Is it still
> consered an "active" arch we support? I haven't seen a single
> alpha-related stable patch in _years_ if at all, which implies to me
> that no one is even using it.
>
> Not that stable patches for architectures are a valid reference for how
> much they are used, but it does give me a good indication of what arches
> have users that actually care about a modern (i.e. within the past 5
> years) kernel.
I get a reasonable number of objections whenever I suggest something that
would cause problems for Alpha. That said, my most recent suggestion
turns out to be mandated by recent versions of the C standard, so I think
that they have no choice but to get their compiler back-ends up to snuff.
(Before C11, a C compiler could legally compile a byte store as a
non-atomic read-modify-write sequence on the surrounding 32-bit quantity.
C11 and later outlaw this practice because it can introduce data races,
even in programs that use nothing but locking for synchronization.
The fix for this was introduced into gcc 4.7.)
Thanx, Paul
next prev parent reply other threads:[~2015-02-08 0:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-07 2:08 [PATCH] llist: Fix missing lockless_dereference() Mathieu Desnoyers
2015-02-07 22:16 ` Greg KH
2015-02-07 22:30 ` Mathieu Desnoyers
2015-02-08 0:18 ` Matt Turner
2015-02-08 0:29 ` Greg KH
2015-02-08 0:47 ` Michael Cree
2015-02-08 0:59 ` Greg KH
2015-02-08 1:12 ` Michael Cree
2015-02-08 1:20 ` Greg KH
2015-02-08 4:25 ` Mathieu Desnoyers
2015-02-10 1:52 ` Huang Ying
2015-02-10 3:42 ` Mathieu Desnoyers
2015-02-10 9:30 ` Michael Cree
2015-02-08 0:09 ` Paul E. McKenney [this message]
2015-02-10 14:03 ` Peter Hurley
2015-02-10 16:38 ` Paul E. McKenney
2015-02-10 17:29 ` Peter Hurley
2015-02-10 18:03 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150208000955.GG5418@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=bobby.prani@gmail.com \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=stable@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).