From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 4 Mar 2015 14:57:58 +0800 From: Peter Chen To: Greg KH CC: Liu Ying , , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Fabio Estevam , , Subject: Re: [PATCH] video: mxsfb: Make sure axi clock is enabled when accessing registers Message-ID: <20150304065757.GB2689@shlinux2> References: <1425448735-21490-1-git-send-email-Ying.Liu@freescale.com> <20150304060817.GA12241@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150304060817.GA12241@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Tue, Mar 03, 2015 at 10:08:17PM -0800, Greg KH wrote: > On Wed, Mar 04, 2015 at 01:58:55PM +0800, Liu Ying wrote: > > The LCDIF engines embedded in i.MX6sl and i.MX6sx SoCs need the axi clock > > as the engine's system clock. The clock should be enabled when accessing > > LCDIF registers, otherwise the kernel would hang up. We should also keep > > the clock being enabled when the engine is being active to scan out frames > > from memory. This patch makes sure the axi clock is enabled when accessing > > registers so that the kernel hang up issue can be fixed. > > > > Reported-by: Peter Chen > > Signed-off-by: Liu Ying > > --- > > drivers/video/fbdev/mxsfb.c | 70 ++++++++++++++++++++++++++++++++++++--------- > > 1 file changed, 56 insertions(+), 14 deletions(-) > > > > This is not the correct way to submit patches for inclusion in the > stable kernel tree. Please read Documentation/stable_kernel_rules.txt > for how to do this properly. > > Hi Greg, I find this system hang issue at v4.0, and it should exist at v3.19 too. Do you mean Ying forget to add tag "Cc: stable@vger.kernel.org # 3.19" at commit log or you think this fix is too large? -- Best Regards, Peter Chen