From: Willy Tarreau <w@1wt.eu>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v3] staging: panel: fix lcd type
Date: Wed, 25 Mar 2015 00:31:51 +0100 [thread overview]
Message-ID: <20150324233151.GB23298@1wt.eu> (raw)
In-Reply-To: <1427194772-4341-1-git-send-email-sudipm.mukherjee@gmail.com>
On Tue, Mar 24, 2015 at 04:29:32PM +0530, Sudip Mukherjee wrote:
> the lcd type as defined in the Kconfig is not matching in the code.
> as a result the rs, rw and en pins were getting interchanged.
> Kconfig defines the value of PANEL_LCD to be 1 if we select custom
> configuration but in the code LCD_TYPE_CUSTOM is defined as 5.
>
> my hardware is LCD_TYPE_CUSTOM, but the pins were assigned to it
> as pins of LCD_TYPE_OLD, and it was not working.
> Now values are corrected with referenece to the values defined in
> Kconfig and it is working.
> checked on JHD204A lcd with LCD_TYPE_CUSTOM configuration.
>
> Cc: <stable@vger.kernel.org> # 2.6.32+
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>
> v3: added the module_parameters
> v2: cc-ed stable
Acked-by: Willy Tarreau <w@1wt.eu>
[ next time I'll read my mails in reverse order :-) ]
Willy
prev parent reply other threads:[~2015-03-24 23:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 10:59 [PATCH v3] staging: panel: fix lcd type Sudip Mukherjee
2015-03-24 23:31 ` Willy Tarreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324233151.GB23298@1wt.eu \
--to=w@1wt.eu \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox