From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 25 Mar 2015 00:31:51 +0100 From: Willy Tarreau To: Sudip Mukherjee Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] staging: panel: fix lcd type Message-ID: <20150324233151.GB23298@1wt.eu> References: <1427194772-4341-1-git-send-email-sudipm.mukherjee@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427194772-4341-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Tue, Mar 24, 2015 at 04:29:32PM +0530, Sudip Mukherjee wrote: > the lcd type as defined in the Kconfig is not matching in the code. > as a result the rs, rw and en pins were getting interchanged. > Kconfig defines the value of PANEL_LCD to be 1 if we select custom > configuration but in the code LCD_TYPE_CUSTOM is defined as 5. > > my hardware is LCD_TYPE_CUSTOM, but the pins were assigned to it > as pins of LCD_TYPE_OLD, and it was not working. > Now values are corrected with referenece to the values defined in > Kconfig and it is working. > checked on JHD204A lcd with LCD_TYPE_CUSTOM configuration. > > Cc: # 2.6.32+ > Signed-off-by: Sudip Mukherjee > --- > > v3: added the module_parameters > v2: cc-ed stable Acked-by: Willy Tarreau [ next time I'll read my mails in reverse order :-) ] Willy