[PATCH] USB: ftdi_sio: Use jtag quirk for SNAP Connect E10

[PATCH] USB: ftdi_sio: Use jtag quirk for SNAP Connect E10

[Doug Goldstein]

This patch uses the existing CALAO Systems ftdi_8u2232c_probe in order
to avoid attaching a TTY to the JTAG port as this board is based on the
CALAO Systems reference design and needs the same fix up.

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
CC: stable <stable@vger.kernel.org>
---
 drivers/usb/serial/ftdi_sio.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 3086dec..27076d7 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -1884,7 +1884,8 @@ static int ftdi_8u2232c_probe(struct usb_serial *serial)
 	struct usb_device *udev = serial->dev;
 
 	if ((udev->manufacturer && !strcmp(udev->manufacturer, "CALAO Systems")) ||
-	    (udev->product && !strcmp(udev->product, "BeagleBone/XDS100V2")))
+	    (udev->product && !strcmp(udev->product, "BeagleBone/XDS100V2")) ||
+		(udev->product && !strcmp(udev->product, "SNAP Connect E10")))
 		return ftdi_jtag_probe(serial);
 
 	return 0;
-- 
2.0.5

Re: [PATCH] USB: ftdi_sio: Use jtag quirk for SNAP Connect E10

[Johan Hovold]

On Mon, Mar 23, 2015 at 08:34:48PM -0500, Doug Goldstein wrote:
> This patch uses the existing CALAO Systems ftdi_8u2232c_probe in order
> to avoid attaching a TTY to the JTAG port as this board is based on the
> CALAO Systems reference design and needs the same fix up.

Thanks for the patch. Could you please provide the full "lsusb -v"
output for the device before I apply it?

Thanks,
Johan

Re: [PATCH] USB: ftdi_sio: Use jtag quirk for SNAP Connect E10

[Doug Goldstein]

On Wed, Mar 25, 2015 at 3:44 AM, Johan Hovold <johan@kernel.org> wrote:
> On Mon, Mar 23, 2015 at 08:34:48PM -0500, Doug Goldstein wrote:
>> This patch uses the existing CALAO Systems ftdi_8u2232c_probe in order
>> to avoid attaching a TTY to the JTAG port as this board is based on the
>> CALAO Systems reference design and needs the same fix up.
>
> Thanks for the patch. Could you please provide the full "lsusb -v"
> output for the device before I apply it?
>
> Thanks,
> Johan

Johan,

This is the "lsusb -v" of the device in question.

Bus 002 Device 114: ID 0403:6010 Future Technology Devices
International, Ltd FT2232C Dual USB-UART/FIFO IC
Device Descriptor:
  bLength                18
  bDescriptorType         1
  bcdUSB               2.00
  bDeviceClass            0 (Defined at Interface level)
  bDeviceSubClass         0
  bDeviceProtocol         0
  bMaxPacketSize0         8
  idVendor           0x0403 Future Technology Devices International, Ltd
  idProduct          0x6010 FT2232C Dual USB-UART/FIFO IC
  bcdDevice            5.00
  iManufacturer           1 Synapse
  iProduct                2 SNAP Connect E10
  iSerial                 0
  bNumConfigurations      1
  Configuration Descriptor:
    bLength                 9
    bDescriptorType         2
    wTotalLength           55
    bNumInterfaces          2
    bConfigurationValue     1
    iConfiguration          0
    bmAttributes         0x80
      (Bus Powered)
    MaxPower              500mA
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        0
      bAlternateSetting       0
      bNumEndpoints           2
      bInterfaceClass       255 Vendor Specific Class
      bInterfaceSubClass    255 Vendor Specific Subclass
      bInterfaceProtocol    255 Vendor Specific Protocol
      iInterface              2 SNAP Connect E10
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x81  EP 1 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0040  1x 64 bytes
        bInterval               0
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x02  EP 2 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0040  1x 64 bytes
        bInterval               0
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        1
      bAlternateSetting       0
      bNumEndpoints           2
      bInterfaceClass       255 Vendor Specific Class
      bInterfaceSubClass    255 Vendor Specific Subclass
      bInterfaceProtocol    255 Vendor Specific Protocol
      iInterface              2 SNAP Connect E10
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x83  EP 3 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0040  1x 64 bytes
        bInterval               0
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x04  EP 4 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0040  1x 64 bytes
        bInterval               0
Device Status:     0x0000
  (Bus Powered)


I'm game for a better way of avoiding having a tty bound to the first
interface. I've been trying to figure out if I can do it via udev as
well but have had no luck there.

-- 
Doug Goldstein

Re: [PATCH] USB: ftdi_sio: Use jtag quirk for SNAP Connect E10

[Johan Hovold]

On Wed, Mar 25, 2015 at 08:51:26AM -0500, Doug Goldstein wrote:
> On Wed, Mar 25, 2015 at 3:44 AM, Johan Hovold <johan@kernel.org> wrote:
> > On Mon, Mar 23, 2015 at 08:34:48PM -0500, Doug Goldstein wrote:
> >> This patch uses the existing CALAO Systems ftdi_8u2232c_probe in order
> >> to avoid attaching a TTY to the JTAG port as this board is based on the
> >> CALAO Systems reference design and needs the same fix up.
> >
> > Thanks for the patch. Could you please provide the full "lsusb -v"
> > output for the device before I apply it?

> This is the "lsusb -v" of the device in question.

Thanks for the info.

> I'm game for a better way of avoiding having a tty bound to the first
> interface. I've been trying to figure out if I can do it via udev as
> well but have had no luck there.

I'm afraid there's not much else we can do as long as people keep
reusing the default chip IDs.

Patch now applied after I cleaned up the existing logic somewhat.

Thanks,
Johan