From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 30 Mar 2015 23:18:45 +0530 From: Vinod Koul To: Peter Ujfalusi Cc: linux@arm.linux.org.uk, dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 2/5] dmaengine: omap-dma: Fix memory leak when terminating running transfer Message-ID: <20150330174845.GM7192@intel.com> References: <1427456155-28990-1-git-send-email-peter.ujfalusi@ti.com> <1427456155-28990-3-git-send-email-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427456155-28990-3-git-send-email-peter.ujfalusi@ti.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Fri, Mar 27, 2015 at 01:35:52PM +0200, Peter Ujfalusi wrote: > In omap_dma_start_desc the vdesc->node is removed from the virt-dma > framework managed lists (to be precise from the desc_issued list). > If a terminate_all comes before the transfer finishes the omap_desc will > not be freed up because it is not in any of the lists and we stopped the > DMA channel so the transfer will not going to complete. > There is no special sequence for leaking memory when using cyclic (audio) > transfer: with every start and stop of a cyclic transfer the driver leaks > struct omap_desc worth of memory. > > Free up the allocated memory directly in omap_dma_terminate_all() since the > framework will not going to do that for us. > > Signed-off-by: Peter Ujfalusi > CC: > CC: Applied, thanks -- ~Vinod > --- > drivers/dma/omap-dma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c > index 1e646d6c8230..6a4c378ee432 100644 > --- a/drivers/dma/omap-dma.c > +++ b/drivers/dma/omap-dma.c > @@ -1002,6 +1002,7 @@ static int omap_dma_terminate_all(struct dma_chan *chan) > * c->desc is NULL and exit.) > */ > if (c->desc) { > + omap_dma_desc_free(&c->desc->vd); > c->desc = NULL; > /* Avoid stopping the dma twice */ > if (!c->paused) > -- > 2.3.3 > --