From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Marcelo Tosatti <mtosatti@redhat.com>,
Andy Lutomirski <luto@amacapital.net>,
stable@vger.kernel.org
Subject: Re: [PATCH] x86: vdso: fix pvclock races with task migration
Date: Tue, 7 Apr 2015 14:47:36 +0200 [thread overview]
Message-ID: <20150407124736.GA2637@potion.brq.redhat.com> (raw)
In-Reply-To: <5523BB51.8090703@redhat.com>
2015-04-07 13:11+0200, Paolo Bonzini:
> On 02/04/2015 20:44, Radim Krčmář wrote:
> > If we were migrated right after __getcpu, but before reading the
> > migration_count, we wouldn't notice that we read TSC of a different
> > VCPU, nor that KVM's bug made pvti invalid, as only migration_count
> > on source VCPU is increased.
> >
> > Change vdso instead of updating migration_count on destination.
> >
> > Fixes: 0a4e6be9ca17 ("x86: kvm: Revert "remove sched notifier for cross-cpu migrations"")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
>
> Applying this, but removing the "Fixes" tag because a guest patch cannot
> fix a host patch (it can work around it or complement it).
I think it was correct. Both are guest only, the revert just missed
some races. (0a4e6be9ca17 has misleading commit message ...)
next prev parent reply other threads:[~2015-04-07 12:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 18:44 [PATCH] x86: vdso: fix pvclock races with task migration Radim Krčmář
2015-04-02 18:59 ` Andy Lutomirski
2015-04-06 20:07 ` Andy Lutomirski
2015-04-06 22:04 ` Paolo Bonzini
2015-04-06 20:57 ` Marcelo Tosatti
2015-04-07 11:11 ` Paolo Bonzini
2015-04-07 12:47 ` Radim Krčmář [this message]
2015-04-07 13:57 ` Paolo Bonzini
2015-04-29 12:07 ` Patch "x86: vdso: fix pvclock races with task migration" has been added to the 4.0-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150407124736.GA2637@potion.brq.redhat.com \
--to=rkrcmar@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).